DM-48468: Turn off gaussian histogram Ks testing by default. #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchiang87
approved these changes
Jan 22, 2025
| @@ -201,6 +201,12 @@ class PhotonTransferCurveExtractConfig(pipeBase.PipelineTaskConfig, | |||
| 'FULL': 'Second order correction.' | |||
| } | |||
| ) | |||
| doKsHistMeasurement = pexConfig.Field( | |||
| dtype=bool, | |||
| doc="Do the Ks test of gaussianity? If False, will be filled with all 0.0; " | |||
There was a problem hiding this comment.
It would be good to state explicitly that it's the ks test pvalues that will be filled with zeros. I'm wondering though if it would make more sense to fill them with 1.0 so that all of the points will be accepted no matter what pvalue threshold is used.
erykoff
force-pushed
the
tickets/DM-48468
branch
from
3f69fee to
5c67fd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.