DM-48174: Update ComCam manual defects #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
force-pushed
the
tickets/DM-48174
branch
2 times, most recently
from
3ff2b64 to
bf7a88f
Compare
…cts. These include the old manual defects plus a few more.
erykoff
force-pushed
the
tickets/DM-48174
branch
2 times, most recently
from
47e9520 to
b9b3b86
Compare
erykoff
force-pushed
the
tickets/DM-48174
branch
from
b9b3b86 to
14ab3df
Compare
erykoff
changed the title
czwa
approved these changes
Jan 29, 2025
| python $OBS_LSST_DIR/python/lsst/obs/lsst/script/write_comcam_manual_defects.py | ||
| ``` | ||
|
|
||
| The output files then have to be edited by hand to set INSTRUME to "ComCam" instead of "LSSTComCam". |
There was a problem hiding this comment.
This should be available as the instrument.policyName, I think, but I see that it's capitalized differently. This works, so I don't think any changes are needed here now.
There was a problem hiding this comment.
Unfortunately, the ComCam for the INSTRUME header is neither a policy thing or an instrument thing but a bug in the header service that people decided not to fix. 🤷
Furthermore, because of the way the calib writing is done, it's impossible to override this (it gets forcefully overwritten at https://github.com/lsst/ip_isr/blob/424a4f6e284da0d1dd0c80969b43ae3a1b70d6f1/python/lsst/ip/isr/calibType.py#L239 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.