Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48174: Update ComCam manual defects #25

Merged
merged 4 commits into from
Jan 29, 2025
Merged

DM-48174: Update ComCam manual defects #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34701da
Replace limited time manual defects with updated all-time manual defe…
erykoff Jan 23, 2025
12445e8
Manually update INSTRUME from LSSTComCam to ComCam.
erykoff Jan 24, 2025
fa4cf6f
Update README for new processing of manual defects.
erykoff Jan 24, 2025
14ab3df
Add larger detector 4 vampire mask.
erykoff Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions comCam/manual_defects/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
This directory contains manual defects for the LSSTComCam instrument.
The LSSTComCam focal plane consists of one raft of ITL sensors.
As we do not have QE scans of LSSTComCam, we have simply taken an average of all the ITL sensors from the LSSTCam sensor QE scans as processed in DM-40164.

The defects are a combination of manually identified phosphorescent regions, warm corners, and other column features that are not currently captured by the defect finding code.

Data Processing
---------------

Look at ingest_manual_defects.py attached to https://rubinobs.atlassian.net/browse/DM-47365
for the steps done to process these defects.
The manual defects were generated by running:
```
python $OBS_LSST_DIR/python/lsst/obs/lsst/script/write_comcam_manual_defects.py
```

The output files then have to be edited by hand to set INSTRUME to "ComCam" instead of "LSSTComCam".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be available as the instrument.policyName, I think, but I see that it's capitalized differently. This works, so I don't think any changes are needed here now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the ComCam for the INSTRUME header is neither a policy thing or an instrument thing but a bug in the header service that people decided not to fix. 🤷
Furthermore, because of the way the calib writing is done, it's impossible to override this (it gets forcefully overwritten at https://github.com/lsst/ip_isr/blob/424a4f6e284da0d1dd0c80969b43ae3a1b70d6f1/python/lsst/ip/isr/calibType.py#L239 )

13 changes: 13 additions & 0 deletions comCam/manual_defects/r22_s00/19700101T000000.ecsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# %ECSV 1.0
# ---
# datatype:
# - {name: x0, datatype: int64}
# - {name: y0, datatype: int64}
# - {name: width, datatype: int64}
# - {name: height, datatype: int64}
# meta: {CALIBCLS: lsst.ip.isr.defects.Defects, CALIBDATE: '1970-01-01T00:00:00', CALIB_ID: instrument=LSSTComCam raftName=R22 detectorName=R22_S00,
# DETECTOR: 0, DET_NAME: R22_S00, DET_SER: ITL-3800C-229, INSTRUME: ComCam, OBSTYPE: manual_defects, RAFTNAME: R22, SLOTNAME: S00,
# defects_SCHEMA: '', defects_VERSION: 2.0}
# schema: astropy-2.0
x0 y0 width height
680 2000 11 966
34 changes: 0 additions & 34 deletions comCam/manual_defects/r22_s00/20241020T000000.ecsv
View file
Open in desktop

This file was deleted.

14 changes: 14 additions & 0 deletions comCam/manual_defects/r22_s01/19700101T000000.ecsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# %ECSV 1.0
# ---
# datatype:
# - {name: x0, datatype: int64}
# - {name: y0, datatype: int64}
# - {name: width, datatype: int64}
# - {name: height, datatype: int64}
# meta: {CALIBCLS: lsst.ip.isr.defects.Defects, CALIBDATE: '1970-01-01T00:00:00', CALIB_ID: instrument=LSSTComCam raftName=R22 detectorName=R22_S01
# detector=1, DETECTOR: 1, DET_NAME: R22_S01, DET_SER: ITL-3800C-251, INSTRUME: ComCam, OBSTYPE: manual_defects, RAFTNAME: R22,
# SLOTNAME: S01, defects_SCHEMA: '', defects_VERSION: 2.0}
# schema: astropy-2.0
x0 y0 width height
0 1300 350 2700
3650 3600 417 400
36 changes: 0 additions & 36 deletions comCam/manual_defects/r22_s01/20241020T000000.ecsv
View file
Open in desktop

This file was deleted.

12 changes: 12 additions & 0 deletions comCam/manual_defects/r22_s02/19700101T000000.ecsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# %ECSV 1.0
# ---
# datatype:
# - {name: x0, datatype: float64}
# - {name: y0, datatype: float64}
# - {name: width, datatype: float64}
# - {name: height, datatype: float64}
# meta: {CALIBCLS: lsst.ip.isr.defects.Defects, CALIBDATE: '1970-01-01T00:00:00', CALIB_ID: instrument=LSSTComCam raftName=R22 detectorName=R22_S02
# detector=2, DETECTOR: 2, DET_NAME: R22_S02, DET_SER: ITL-3800C-215, INSTRUME: ComCam, OBSTYPE: manual_defects, RAFTNAME: R22,
# SLOTNAME: S02, defects_SCHEMA: '', defects_VERSION: 2.0}
# schema: astropy-2.0
x0 y0 width height
34 changes: 0 additions & 34 deletions comCam/manual_defects/r22_s02/20241020T000000.ecsv
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions comCam/manual_defects/r22_s10/19700101T000000.ecsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# %ECSV 1.0
# ---
# datatype:
# - {name: x0, datatype: int64}
# - {name: y0, datatype: int64}
# - {name: width, datatype: int64}
# - {name: height, datatype: int64}
# meta: {CALIBCLS: lsst.ip.isr.defects.Defects, CALIBDATE: '1970-01-01T00:00:00', CALIB_ID: instrument=LSSTComCam raftName=R22 detectorName=R22_S10
# detector=3, DETECTOR: 3, DET_NAME: R22_S10, DET_SER: ITL-3800C-326, INSTRUME: ComCam, OBSTYPE: manual_defects, RAFTNAME: R22,
# SLOTNAME: S10, defects_SCHEMA: '', defects_VERSION: 2.0}
# schema: astropy-2.0
x0 y0 width height
3600 0 472 900
34 changes: 0 additions & 34 deletions comCam/manual_defects/r22_s10/20241020T000000.ecsv
View file
Open in desktop

This file was deleted.

16 changes: 16 additions & 0 deletions comCam/manual_defects/r22_s11/19700101T000000.ecsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# %ECSV 1.0
# ---
# datatype:
# - {name: x0, datatype: int64}
# - {name: y0, datatype: int64}
# - {name: width, datatype: int64}
# - {name: height, datatype: int64}
# meta: {CALIBCLS: lsst.ip.isr.defects.Defects, CALIBDATE: '1970-01-01T00:00:00', CALIB_ID: instrument=LSSTComCam raftName=R22 detectorName=R22_S11
# detector=4, DETECTOR: 4, DET_NAME: R22_S11, DET_SER: ITL-3800C-283, INSTRUME: ComCam, OBSTYPE: manual_defects, RAFTNAME: R22,
# SLOTNAME: S11, defects_SCHEMA: '', defects_VERSION: 2.0}
# schema: astropy-2.0
x0 y0 width height
2534 0 7 2000
2510 930 24 55
2541 930 24 55
3389 2000 29 2000
35 changes: 0 additions & 35 deletions comCam/manual_defects/r22_s11/20241020T000000.ecsv
View file
Open in desktop

This file was deleted.

16 changes: 16 additions & 0 deletions comCam/manual_defects/r22_s12/19700101T000000.ecsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# %ECSV 1.0
# ---
# datatype:
# - {name: x0, datatype: int64}
# - {name: y0, datatype: int64}
# - {name: width, datatype: int64}
# - {name: height, datatype: int64}
# meta: {CALIBCLS: lsst.ip.isr.defects.Defects, CALIBDATE: '1970-01-01T00:00:00', CALIB_ID: instrument=LSSTComCam raftName=R22 detectorName=R22_S12
# detector=5, DETECTOR: 5, DET_NAME: R22_S12, DET_SER: ITL-3800C-243, INSTRUME: ComCam, OBSTYPE: manual_defects, RAFTNAME: R22,
# SLOTNAME: S12, defects_SCHEMA: '', defects_VERSION: 2.0}
# schema: astropy-2.0
x0 y0 width height
500 0 10 2000
1008 0 15 2000
1522 0 10 2000
2031 0 10 2000
38 changes: 0 additions & 38 deletions comCam/manual_defects/r22_s12/20241020T000000.ecsv
View file
Open in desktop

This file was deleted.

12 changes: 12 additions & 0 deletions comCam/manual_defects/r22_s20/19700101T000000.ecsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# %ECSV 1.0
# ---
# datatype:
# - {name: x0, datatype: float64}
# - {name: y0, datatype: float64}
# - {name: width, datatype: float64}
# - {name: height, datatype: float64}
# meta: {CALIBCLS: lsst.ip.isr.defects.Defects, CALIBDATE: '1970-01-01T00:00:00', CALIB_ID: instrument=LSSTComCam raftName=R22 detectorName=R22_S20
# detector=6, DETECTOR: 6, DET_NAME: R22_S20, DET_SER: ITL-3800C-319, INSTRUME: ComCam, OBSTYPE: manual_defects, RAFTNAME: R22,
# SLOTNAME: S20, defects_SCHEMA: '', defects_VERSION: 2.0}
# schema: astropy-2.0
x0 y0 width height
34 changes: 0 additions & 34 deletions comCam/manual_defects/r22_s20/20241020T000000.ecsv
View file
Open in desktop

This file was deleted.

12 changes: 12 additions & 0 deletions comCam/manual_defects/r22_s21/19700101T000000.ecsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# %ECSV 1.0
# ---
# datatype:
# - {name: x0, datatype: float64}
# - {name: y0, datatype: float64}
# - {name: width, datatype: float64}
# - {name: height, datatype: float64}
# meta: {CALIBCLS: lsst.ip.isr.defects.Defects, CALIBDATE: '1970-01-01T00:00:00', CALIB_ID: instrument=LSSTComCam raftName=R22 detectorName=R22_S21
# detector=7, DETECTOR: 7, DET_NAME: R22_S21, DET_SER: ITL-3800C-209, INSTRUME: ComCam, OBSTYPE: manual_defects, RAFTNAME: R22,
# SLOTNAME: S21, defects_SCHEMA: '', defects_VERSION: 2.0}
# schema: astropy-2.0
x0 y0 width height
Loading
Loading