Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small spec inconsistencies with model types #12968

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix small spec inconsistencies with model types #12968

merged 1 commit into from
Nov 13, 2023

Conversation

tristen
Copy link
Member

@tristen tristen commented Nov 12, 2023

  • Provide a default value of "" for model-id
  • Change the model-emissive-strength unit value to intensity

@tristen
Fix small spec inconsistencies with model types
d6b4fee 
- Provide a default value of `""` for `model-id`
- Change `model-emissive-strength` unit value to `intensity`
@tristen tristen requested a review from a team as a code owner November 12, 2023 15:08
@mourner mourner merged commit abbc512 into main Nov 13, 2023
28 checks passed
@mourner mourner deleted the GLJS-573 branch November 13, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristen @mourner