New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing MSVC build on GitHub Actions #80

Merged

martinmoene merged 1 commit into martinmoene:master from striezel-stash:fix-windows-2022-build-failure

Mar 14, 2025

Contributor

striezel commented Mar 12, 2025 •

edited

Loading

Fixes the build failure with MSVC on Windows 2022.

See https://github.com/martinmoene/expected-lite/actions/runs/13823506911/job/38673977228?pr=79 for the failure. Boils down to:

D:\a\expected-lite\expected-lite\test\expected.t.cpp(2245,13): error C3861: 'assert': identifier not found [D:\a\expected-lite\expected-lite\build\test\expected-lite-cpplatest.t.vcxproj]

So adding the header <cassert> which declares the assert macro should fix the error.


          Fix failing MSVC build on GitHub Actions

51a9bf5

striezel mentioned this pull request

Fix failing Clang builds on GitHub Actions #79

Merged

martinmoene merged commit f72aacb into martinmoene:master

5 of 7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet