Skip to content

Adapt to rocq#19987 #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Adapt to rocq#19987 #1532

merged 1 commit into from
May 22, 2025

Conversation

Tragicus
Copy link
Collaborator

Motivation for this change

rocq-prover/rocq#19987 refolds terms before using them to instantiate evars. In classical/functions.v, there is a lemma (image_subP) that uses homomorphism_1, which introduces eta-expansions. Due to unfoldings in the previous algorithm, these eta-expansions were removed, whereas they are not now, which makes rewrite's matching algorithm fail. In theories/function_spaces, there is a second order unification problem which is solved differently.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@Tragicus
Copy link
Collaborator Author

My first round of overlays should be ready soon. Is there something to do here (e.g. rerunning the CI if it is fixed)?

@affeldt-aist affeldt-aist self-requested a review May 20, 2025 12:01
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@affeldt-aist affeldt-aist merged commit 1bf8c1c into math-comp:master May 22, 2025
43 of 45 checks passed
@Tragicus Tragicus deleted the rocq19987 branch May 23, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants