Refold before evar instantiation #19987

Tragicus · 2025-01-07T12:04:58Z

Until now, the algorithm unfolded terms blindly and instantiated an evar with whatever term was on the other side. Now, we remember the terms from the initial unification problem, and whenever we reach a problem of the form ?e = t, we replace t with its initial version.
This PR does the minimal change that changes the behavior of the unification algorithm as intended, but this makes the control flow a bit awkward and some computations are done twice, which is a bit inefficient. Should I try to be a bit more aggressive and rewrite some of the code?

Fixes / closes #????

Added / updated test-suite.

Added changelog.
Added / updated documentation.
- Documented any new / changed user messages.
- Updated documented syntax by running make doc_gram_rsts.

Opened overlay pull requests.

Overlays:

gares · 2025-01-07T13:23:50Z

@coqbot bench

coqbot-app · 2025-01-07T22:27:28Z

🏁 Bench results:

┌─────────────────────────────────────┬───────────────────────┬─────────────────────────────────────┬─────────────────────────┐
│                                     │     user time [s]     │          CPU instructions           │  max resident mem [KB]  │
│                                     │                       │                                     │                         │
│            package_name             │  NEW     OLD    PDIFF │      NEW            OLD       PDIFF │   NEW      OLD    PDIFF │
├─────────────────────────────────────┼───────────────────────┼─────────────────────────────────────┼─────────────────────────┤
│                       coq-equations │   6.91    7.10  -2.68 │   47029485945    47024399829   0.01 │  390336   388596   0.45 │
│                          coq-stdlib │ 187.89  189.58  -0.89 │ 1181739919276  1181696109342   0.00 │  532660   533332  -0.13 │
│                       coq-fiat-core │  56.11   56.45  -0.60 │  341057940535   341175081981  -0.03 │  473588   474472  -0.19 │
│                    coq-fiat-parsers │ 270.61  272.04  -0.53 │ 2106290219301  2105950413535   0.02 │ 2295512  2293532   0.09 │
│                            coq-core │  74.57   74.87  -0.40 │  541584302660   541622084437  -0.01 │  485268   485160   0.02 │
│                 coq-metacoq-erasure │ 515.35  517.12  -0.34 │ 3579815279037  3573514860516   0.18 │ 1821304  1824448  -0.17 │
│         coq-rewriter-perf-SuperFast │ 756.10  758.55  -0.32 │ 5912847787375  5912237388520   0.01 │ 1379000  1377236   0.13 │
│          coq-performance-tests-lite │ 902.37  904.81  -0.27 │ 7294476587492  7284817177578   0.13 │ 2469104  2470336  -0.05 │
│                  coq-metacoq-common │  66.63   66.80  -0.25 │  436060218079   435976582098   0.02 │ 1052520  1050064   0.23 │
│            coq-metacoq-translations │  16.76   16.80  -0.24 │  120426906427   120408204111   0.02 │  774868   772828   0.26 │
│               coq-mathcomp-fingroup │  25.99   26.04  -0.19 │  169328654076   169232083869   0.06 │  591316   589244   0.35 │
│                             coq-vst │ 853.94  855.48  -0.18 │ 6475714073501  6475217517501   0.01 │ 2218036  2214704   0.15 │
│                   coq-metacoq-utils │  22.76   22.80  -0.18 │  149370960530   149329650970   0.03 │  598760   598368   0.07 │
│                      coq-coquelicot │  36.23   36.29  -0.17 │  218177131455   218153317529   0.01 │  817700   817468   0.03 │
│                           coq-verdi │  43.64   43.70  -0.14 │  293299903777   293338999231  -0.01 │  528664   532400  -0.70 │
│                      coq-verdi-raft │ 533.21  533.61  -0.07 │ 3703590081697  3704590964871  -0.03 │  824096   836988  -1.54 │
│                 coq-category-theory │ 592.39  592.67  -0.05 │ 4429349901206  4428761492191   0.01 │  917956   981824  -6.51 │
│ coq-neural-net-interp-computed-lite │ 232.09  232.19  -0.04 │ 2244805485804  2244765908494   0.00 │  863588   865956  -0.27 │
│                coq-metacoq-template │ 146.49  146.51  -0.01 │  985614971489   985539629615   0.01 │ 1053616  1050260   0.32 │
│                        coq-rewriter │ 331.89  331.71   0.05 │ 2496712828296  2497204975808  -0.02 │ 1305200  1308696  -0.27 │
│                        coq-compcert │ 303.33  302.88   0.15 │ 2002039068455  2002152172587  -0.01 │ 1183860  1181964   0.16 │
│             coq-metacoq-safechecker │ 344.22  343.24   0.29 │ 2631523883769  2633899081278  -0.09 │ 1670176  1669784   0.02 │
│               coq-mathcomp-solvable │  90.04   89.77   0.30 │  630380602344   628500746592   0.30 │  946984   946876   0.01 │
│                         coq-coqutil │  42.44   42.29   0.35 │  267634556898   267561895031   0.03 │  560448   557828   0.47 │
│              coq-mathcomp-character │  74.87   74.59   0.38 │  513022774415   512243136548   0.15 │ 1181104  1180956   0.01 │
│                        coq-bedrock2 │ 322.69  320.83   0.58 │ 2710482236396  2711156433429  -0.02 │  895228   893584   0.18 │
│               coq-engine-bench-lite │ 129.73  128.97   0.59 │  968183321277   966225116325   0.20 │ 1076564  1076848  -0.03 │
│              coq-mathcomp-ssreflect │  88.24   87.61   0.72 │  600608498594   599200604406   0.23 │ 1635248  1637960  -0.17 │
│                  coq-mathcomp-field │  91.55   90.29   1.40 │  652151883310   646290054652   0.91 │ 1237468  1255856  -1.46 │
│                           rocq-core │   6.02    5.92   1.69 │   36478760827    36481294303  -0.01 │  436752   439448  -0.61 │
│                coq-mathcomp-algebra │ 164.50  160.62   2.42 │ 1149445502597  1127210229650   1.97 │ 1187236  1188608  -0.12 │
│                   coq-metacoq-pcuic │ 691.49  673.25   2.71 │ 4494550051066  4382440846182   2.56 │ 2259236  2260032  -0.04 │
│                   coq-iris-examples │ 403.41  389.55   3.56 │ 2709351395576  2606732263614   3.94 │ 1102112  1101796   0.03 │
└─────────────────────────────────────┴───────────────────────┴─────────────────────────────────────┴─────────────────────────┘

INFO: failed to install
coq-bignums (in NEW)
coq-hott (in NEW)
coq-mathcomp-odd-order (in NEW)
coq-mathcomp-analysis (dependency install failed in NEW)
coq-unimath (in NEW)
coq-fourcolor (in NEW)

coq-math-classes (dependency coq-bignums failed)
coq-corn (dependency coq-bignums failed)
coq-color (dependency coq-bignums failed)
coq-coqprime (dependency coq-bignums failed)
coq-fiat-crypto-with-bedrock (dependency coq-bignums failed)

🐢 Top 25 slow downs

┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│                                                  TOP 25 SLOW DOWNS                                                   │
│                                                                                                                      │
│   OLD      NEW     DIFF     %DIFF     Ln                FILE                                                         │
├──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│  0.1330   4.1990  4.0660   3057.14%  1867  coq-metacoq-pcuic/pcuic/theories/PCUICSR.v.html                           │
│  8.0710  11.0050  2.9340     36.35%   591  coq-iris-examples/theories/logrel/F_mu_ref_conc/binary/fundamental.v.html │
│  8.0830  10.9440  2.8610     35.40%   581  coq-iris-examples/theories/logrel/F_mu_ref_conc/binary/fundamental.v.html │
│  7.9850  10.8230  2.8380     35.54%   580  coq-iris-examples/theories/logrel/F_mu_ref_conc/binary/fundamental.v.html │
│  0.2750   1.8080  1.5330    557.45%   177  coq-mathcomp-algebra/mathcomp/algebra/intdiv.v.html                       │
│  0.0220   1.2510  1.2290   5586.36%   302  coq-metacoq-pcuic/pcuic/theories/PCUICCasesHelper.v.html                  │
│  0.0210   1.1660  1.1450   5452.38%   435  coq-metacoq-pcuic/pcuic/theories/PCUICInductiveInversion.v.html           │
│  0.0450   1.0930  1.0480   2328.89%  1902  coq-metacoq-pcuic/pcuic/theories/PCUICSR.v.html                           │
│  0.0140   1.0320  1.0180   7271.43%  1885  coq-metacoq-pcuic/pcuic/theories/PCUICSR.v.html                           │
│ 63.4600  64.4720  1.0120      1.59%   609  coq-bedrock2/bedrock2/src/bedrock2Examples/lightbulb.v.html               │
│  0.0160   1.0210  1.0050   6281.25%  1861  coq-metacoq-pcuic/pcuic/theories/PCUICSR.v.html                           │
│  0.0400   1.0360  0.9960   2490.00%  2065  coq-metacoq-pcuic/pcuic/theories/PCUICSR.v.html                           │
│  0.0300   1.0080  0.9780   3260.00%   531  coq-metacoq-erasure/erasure/theories/ESubstitution.v.html                 │
│  0.0060   0.9330  0.9270  15450.00%  3047  coq-metacoq-pcuic/pcuic/theories/PCUICExpandLetsCorrectness.v.html        │
│  0.0100   0.7910  0.7810   7810.00%   793  coq-metacoq-pcuic/pcuic/theories/PCUICCasesHelper.v.html                  │
│  0.0300   0.8000  0.7700   2566.67%   126  coq-metacoq-pcuic/pcuic/theories/Typing/PCUICRenameTyp.v.html             │
│ 46.3670  46.8170  0.4500      0.97%   110  coq-bedrock2/bedrock2/src/bedrock2Examples/full_mul.v.html                │
│ 10.3170  10.7330  0.4160      4.03%   325  coq-engine-bench-lite/coq/PerformanceDemos/one_step_reduction.v.html      │
│  0.0130   0.4270  0.4140   3184.62%  2483  coq-metacoq-pcuic/pcuic/theories/PCUICInductives.v.html                   │
│ 10.4990  10.9040  0.4050      3.86%   214  coq-engine-bench-lite/coq/PerformanceDemos/one_step_reduction.v.html      │
│  0.0190   0.3980  0.3790   1994.74%   769  coq-metacoq-pcuic/pcuic/theories/PCUICCasesHelper.v.html                  │
│  0.0230   0.4010  0.3780   1643.48%   658  coq-metacoq-pcuic/pcuic/theories/PCUICCasesHelper.v.html                  │
│  0.0170   0.3930  0.3760   2211.76%   792  coq-metacoq-pcuic/pcuic/theories/PCUICCasesHelper.v.html                  │
│  0.0460   0.4090  0.3630    789.13%   676  coq-metacoq-pcuic/pcuic/theories/PCUICCasesHelper.v.html                  │
│  0.0790   0.4380  0.3590    454.43%    84  coq-metacoq-pcuic/pcuic/theories/Typing/PCUICRenameTyp.v.html             │
└──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

🐇 Top 25 speed ups

┌────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│                                                            TOP 25 SPEED UPS                                                            │
│                                                                                                                                        │
│   OLD       NEW      DIFF     %DIFF     Ln                    FILE                                                                     │
├────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│  17.8600   17.0050  -0.8550    -4.79%    32  coq-performance-tests-lite/src/pattern.v.html                                             │
│  42.6870   41.9860  -0.7010    -1.64%   834  coq-vst/veric/binop_lemmas4.v.html                                                        │
│  38.6950   38.1530  -0.5420    -1.40%   224  coq-performance-tests-lite/PerformanceExperiments/rewrite_lift_lets_map.v.html            │
│  36.4320   36.0050  -0.4270    -1.17%   139  coq-fiat-parsers/src/Parsers/Refinement/SharpenedJSON.v.html                              │
│ 100.4130  100.0330  -0.3800    -0.38%   999  coq-performance-tests-lite/src/fiat_crypto_via_setoid_rewrite_standalone.v.html           │
│ 100.5450  100.1960  -0.3490    -0.35%   968  coq-performance-tests-lite/src/fiat_crypto_via_setoid_rewrite_standalone.v.html           │
│  18.3110   18.0040  -0.3070    -1.68%   481  coq-verdi-raft/theories/RaftProofs/EndToEndLinearizability.v.html                         │
│   0.6460    0.3680  -0.2780   -43.03%   333  coq-metacoq-pcuic/pcuic/theories/PCUICCasesHelper.v.html                                  │
│   0.5400    0.2810  -0.2590   -47.96%   133  coq-metacoq-pcuic/pcuic/theories/Typing/PCUICRenameTyp.v.html                             │
│   8.5320    8.2950  -0.2370    -2.78%   673  coq-rewriter/src/Rewriter/Rewriter/Wf.v.html                                              │
│  39.0380   38.8140  -0.2240    -0.57%   236  coq-rewriter-perf-SuperFast/src/Rewriter/Rewriter/Examples/PerfTesting/LiftLetsMap.v.html │
│  31.2670   31.0520  -0.2150    -0.69%    97  coq-vst/veric/binop_lemmas5.v.html                                                        │
│   0.1910    0.0020  -0.1890   -98.95%   343  coq-metacoq-erasure/erasure/theories/EWcbvEvalCstrsAsBlocksInd.v.html                     │
│  11.4870   11.3010  -0.1860    -1.62%   126  coq-vst/veric/binop_lemmas6.v.html                                                        │
│   4.7930    4.6080  -0.1850    -3.86%  2761  coq-metacoq-safechecker/safechecker/theories/PCUICTypeChecker.v.html                      │
│   0.1710    0.0000  -0.1710  -100.00%   466  coq-metacoq-erasure/erasure/theories/EArities.v.html                                      │
│  11.4820   11.3140  -0.1680    -1.46%   410  coq-verdi-raft/theories/RaftProofs/LeaderLogsLogMatchingProof.v.html                      │
│   0.5660    0.4030  -0.1630   -28.80%     9  coq-mathcomp-character/mathcomp/character/classfun.v.html                                 │
│   0.1670    0.0050  -0.1620   -97.01%   300  coq-metacoq-pcuic/pcuic/theories/PCUICCasesHelper.v.html                                  │
│   5.2680    5.1080  -0.1600    -3.04%   198  coq-compcert/x86/Op.v.html                                                                │
│   0.1630    0.0030  -0.1600   -98.16%   115  coq-mathcomp-field/mathcomp/field/algebraics_fundamentals.v.html                          │
│  38.9850   38.8260  -0.1590    -0.41%   236  coq-rewriter/src/Rewriter/Rewriter/Examples/PerfTesting/LiftLetsMap.v.html                │
│   0.4330    0.2750  -0.1580   -36.49%    10  coq-mathcomp-character/mathcomp/character/vcharacter.v.html                               │
│   9.9620    9.8060  -0.1560    -1.57%   496  coq-rewriter/src/Rewriter/Rewriter/Wf.v.html                                              │
│   0.1560    0.0010  -0.1550   -99.36%   236  coq-mathcomp-field/mathcomp/field/separable.v.html                                        │
└────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

🪑 GitLab Bench Job

gares · 2025-01-08T10:43:37Z

There are some slowdowns to be investigated, especially the metacoq one seems too huge to be acceptable.
It may just be that an intermediate goal is different and the next tactic does silly things.
The iris ones seems also relevant to me.

Until now, the algorithm unfolded terms blindly and instantiated an evar with whatever term was on the other side. Now, we remember the terms from the initial unification problem, and whenever we reach a problem of the form `?e = t`, we replace `t` with its initial version.

rocq-prover/rocq#19987 refolds terms before using them to instantiate evars. There is one instance where we need to unfold by hand.

Tragicus · 2025-05-23T08:38:06Z

MetaRocq/metarocq#1152 is only a small performance improvement, so I think we might as well retry the CI now.

gares · 2025-05-31T14:40:36Z

@coqbot bench

coqbot-app · 2025-05-31T19:33:58Z

🏁 Bench results:

┌─────────────────────────────────────┬─────────────────────────┬───────────────────────────────────────┬─────────────────────────┐
│                                     │      user time [s]      │           CPU instructions            │  max resident mem [KB]  │
│                                     │                         │                                       │                         │
│            package_name             │   NEW      OLD    PDIFF │      NEW             OLD        PDIFF │   NEW      OLD    PDIFF │
├─────────────────────────────────────┼─────────────────────────┼───────────────────────────────────────┼─────────────────────────┤
│                           rocq-core │    6.54     6.68  -2.10 │    40865695486     40890125447  -0.06 │  439508   437572   0.44 │
│                            coq-core │    2.85     2.90  -1.72 │    19519988846     19516013184   0.02 │   93828    93932  -0.11 │
│                        coq-bedrock2 │  345.49   350.43  -1.41 │  2917767643489   2918240577130  -0.02 │  850300   849904   0.05 │
│               coq-engine-bench-lite │  124.82   125.82  -0.79 │   934132156072    936054088124  -0.21 │ 1077212  1079072  -0.17 │
│                      coq-verdi-raft │  533.39   536.50  -0.58 │  3709654850059   3709329918200   0.01 │  832172   831708   0.06 │
│                    coq-fiat-parsers │  277.79   279.22  -0.51 │  2147259770162   2147004527065   0.01 │ 2294456  2294780  -0.01 │
│                    coq-math-classes │   86.62    86.98  -0.41 │   530762668537    530645959157   0.02 │  507024   507696  -0.13 │
│                           coq-color │  251.97   252.60  -0.25 │  1585955478826   1585968770837  -0.00 │ 1052572  1052472   0.01 │
│                           coq-verdi │   44.16    44.23  -0.16 │   295223950106    295215651587   0.00 │  529000   523556   1.04 │
│                        rocq-runtime │   73.58    73.69  -0.15 │   536252448644    536084449102   0.03 │  490168   490016   0.03 │
│                         rocq-stdlib │  244.16   244.44  -0.11 │  1550165718017   1550139397632   0.00 │  624148   626796  -0.42 │
│                             coq-vst │  872.16   872.81  -0.07 │  6581136296320   6581885103249  -0.01 │ 2241448  2241908  -0.02 │
│                        coq-compcert │  312.64   312.65  -0.00 │  2043261643738   2043234418808   0.00 │ 1112124  1107460   0.42 │
│                         coq-coqutil │   44.24    44.24   0.00 │   277373555835    277403726157  -0.01 │  559752   560048  -0.05 │
│                       coq-fiat-core │   57.82    57.80   0.03 │   349072202867    349031070451   0.01 │  481040   480944   0.02 │
│          coq-performance-tests-lite │  907.86   907.43   0.05 │  7304013947388   7291322910737   0.17 │ 2474300  2471592   0.11 │
│                            coq-hott │  158.13   157.89   0.15 │  1111771035894   1096233343381   1.42 │  463288   463564  -0.06 │
│                        coq-coqprime │   52.49    52.34   0.29 │   359576318301    359593596721  -0.00 │  794972   794764   0.03 │
│ coq-neural-net-interp-computed-lite │  234.58   233.77   0.35 │  2247521533673   2247441892748   0.00 │  855840   857912  -0.24 │
│                        rocq-bignums │   30.72    30.55   0.56 │   194275253060    194275490008  -0.00 │  481372   481376  -0.00 │
│                   coq-iris-examples │  382.92   380.79   0.56 │  2533178982746   2499022738033   1.37 │ 1092268  1096784  -0.41 │
│                         coq-unimath │ 1815.43  1804.57   0.60 │ 15093825829560  15009157795927   0.56 │ 1043700  1043760  -0.01 │
└─────────────────────────────────────┴─────────────────────────┴───────────────────────────────────────┴─────────────────────────┘

INFO: failed to install
rocq-elpi (in NEW)
rocq-equations (in NEW)
coq-rewriter (in NEW)

rocq-mathcomp-ssreflect (dependency rocq-elpi failed)
rocq-mathcomp-fingroup (dependency rocq-elpi failed)
rocq-mathcomp-algebra (dependency rocq-elpi failed)
rocq-mathcomp-solvable (dependency rocq-elpi failed)
rocq-mathcomp-field (dependency rocq-elpi failed)
rocq-mathcomp-character (dependency rocq-elpi failed)
coq-mathcomp-odd-order (dependency rocq-elpi failed)
coq-mathcomp-analysis (dependency rocq-elpi failed)
coq-corn (dependency rocq-elpi failed)
rocq-metarocq-utils (dependency rocq-equations failed)
rocq-metarocq-common (dependency rocq-equations failed)
rocq-metarocq-template (dependency rocq-equations failed)
rocq-metarocq-pcuic (dependency rocq-equations failed)
rocq-metarocq-safechecker (dependency rocq-equations failed)
rocq-metarocq-erasure (dependency rocq-equations failed)
rocq-metarocq-translations (dependency rocq-equations failed)
coq-fiat-crypto-with-bedrock (dependency coq-rewriter failed)
coq-coquelicot (dependency rocq-elpi failed)
coq-fourcolor (dependency rocq-elpi failed)
coq-rewriter-perf-SuperFast (dependency coq-rewriter failed)
coq-category-theory (dependency rocq-equations failed)

🐢 Top 25 slow downs

┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│                                                              TOP 25 SLOW DOWNS                                                               │
│                                                                                                                                              │
│   OLD     NEW     DIFF     %DIFF     Ln                     FILE                                                                             │
├──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│   0.186    1.31  1.1193    602.38%   170  coq-unimath/UniMath/ModelCategories/Generated/OneStepMonad.v.html                                  │
│   0.183    1.29  1.1115    606.64%   238  coq-unimath/UniMath/ModelCategories/Generated/OneStepMonadSmall.v.html                             │
│   0.204    1.19  0.9903    485.35%   196  coq-unimath/UniMath/ModelCategories/Generated/OneStepMonad.v.html                                  │
│     200     201  0.8305      0.41%     8  coq-neural-net-interp-computed-lite/theories/MaxOfTwoNumbersSimpler/Computed/AllLogits.v.html      │
│ 0.00368   0.718  0.7140  19390.66%   264  coq-hott/theories/Algebra/AbSES/PullbackFiberSequence.v.html                                       │
│  0.0183   0.684  0.6661   3642.66%   303  coq-unimath/UniMath/CategoryTheory/DisplayedCats/Fiberwise/DependentSums.v.html                    │
│  0.0169   0.680  0.6631   3926.99%   301  coq-unimath/UniMath/CategoryTheory/DisplayedCats/Fiberwise/DependentProducts.v.html                │
│   0.179   0.780  0.6005    334.95%   380  coq-unimath/UniMath/CategoryTheory/DisplayedCats/Fiberwise/DependentProducts.v.html                │
│  0.0198   0.462  0.4424   2236.08%   369  coq-hott/theories/Algebra/AbSES/PullbackFiberSequence.v.html                                       │
│  42.476  42.918  0.4420      1.04%   834  coq-vst/veric/binop_lemmas4.v.html                                                                 │
│    7.41    7.80  0.3983      5.38%   604  coq-unimath/UniMath/CategoryTheory/EnrichedCats/Colimits/Examples/StructureEnrichedColimits.v.html │
│    2.92    3.19  0.2651      9.07%   597  coq-unimath/UniMath/CategoryTheory/DisplayedCats/Examples/SetGroupoidComprehension.v.html          │
│   0.254   0.506  0.2519     99.10%  2011  coq-unimath/UniMath/CategoryTheory/ExactCategories/ExactCategories.v.html                          │
│   0.274   0.522  0.2480     90.48%  2109  coq-unimath/UniMath/CategoryTheory/ExactCategories/ExactCategories.v.html                          │
│   0.280   0.524  0.2439     87.13%  2093  coq-unimath/UniMath/CategoryTheory/ExactCategories/ExactCategories.v.html                          │
│   0.267   0.510  0.2434     91.18%  2081  coq-unimath/UniMath/CategoryTheory/ExactCategories/ExactCategories.v.html                          │
│ 0.00170   0.240  0.2388  14070.12%   159  coq-unimath/UniMath/CategoryTheory/DisplayedCats/Fiberwise/DependentProducts.v.html                │
│ 0.00157   0.235  0.2337  14892.22%   160  coq-unimath/UniMath/CategoryTheory/DisplayedCats/Fiberwise/DependentSums.v.html                    │
│    12.3    12.5  0.1983      1.61%   930  coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html              │
│  0.0664   0.242  0.1752    263.85%   794  coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/PERMonomorphisms.v.html            │
│  0.0636   0.237  0.1732    272.39%   848  coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/PERMonomorphisms.v.html            │
│   0.121   0.283  0.1612    132.77%  1227  coq-unimath/UniMath/CategoryTheory/DisplayedCats/Examples/Reindexing.v.html                        │
│    8.28    8.43  0.1506      1.82%   648  coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html              │
│    8.57    8.72  0.1504      1.75%   950  coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html              │
│  0.0523   0.197  0.1450    277.33%   776  coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/PERMonomorphisms.v.html            │
└──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

🐇 Top 25 speed ups

┌─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│                                                        TOP 25 SPEED UPS                                                         │
│                                                                                                                                 │
│  OLD     NEW      DIFF     %DIFF    Ln                    FILE                                                                  │
├─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│  66.1      62.0  -4.1371   -6.26%    609  coq-bedrock2/bedrock2/src/bedrock2Examples/lightbulb.v.html                           │
│  19.2      18.8  -0.3602   -1.88%    481  coq-verdi-raft/theories/RaftProofs/EndToEndLinearizability.v.html                     │
│  16.8      16.4  -0.3204   -1.91%    905  coq-unimath/UniMath/ModelCategories/Generated/LNWFSCocomplete.v.html                  │
│  11.8      11.5  -0.2711   -2.31%    410  coq-verdi-raft/theories/RaftProofs/LeaderLogsLogMatchingProof.v.html                  │
│  10.1      9.83  -0.2493   -2.47%    325  coq-engine-bench-lite/coq/PerformanceDemos/one_step_reduction.v.html                  │
│  10.2      9.96  -0.2416   -2.37%    214  coq-engine-bench-lite/coq/PerformanceDemos/one_step_reduction.v.html                  │
│   101       101  -0.2048   -0.20%    968  coq-performance-tests-lite/src/fiat_crypto_via_setoid_rewrite_standalone.v.html       │
│  26.4      26.2  -0.1946   -0.74%    375  coq-unimath/UniMath/ModelCategories/Generated/LNWFSMonoidalStructure.v.html           │
│ 0.188  0.000650  -0.1873  -99.65%  14865  coq-coqprime/src/Coqprime/examples/BasePrimes.v.html                                  │
│  36.6      36.4  -0.1869   -0.51%    139  coq-fiat-parsers/src/Parsers/Refinement/SharpenedJSON.v.html                          │
│ 3.753      3.57  -0.1830   -4.88%    126  coq-vst/veric/Clight_mapsto_memory_block.v.html                                       │
│  1.32      1.17  -0.1531  -11.61%    196  coq-unimath/UniMath/HomologicalAlgebra/KATriangulated.v.html                          │
│  48.6      48.5  -0.1433   -0.29%    376  coq-unimath/UniMath/ModelCategories/Generated/LNWFSMonoidalStructure.v.html           │
│  7.67      7.53  -0.1412   -1.84%    420  coq-engine-bench-lite/coq/PerformanceDemos/one_step_reduction.v.html                  │
│  24.0      23.9  -0.1368   -0.57%    558  coq-bedrock2/bedrock2/src/bedrock2Examples/insertionsort.v.html                       │
│   101       101  -0.1343   -0.13%    999  coq-performance-tests-lite/src/fiat_crypto_via_setoid_rewrite_standalone.v.html       │
│  7.81      7.68  -0.1260   -1.61%     31  coq-performance-tests-lite/src/pattern.v.html                                         │
│ 0.114   0.00231  -0.1119  -97.97%    202  coq-iris-examples/theories/logatom/counter_with_backup/counter_proof.v.html           │
│ 0.134    0.0228  -0.1108  -82.91%    287  coq-iris-examples/theories/logrel/F_mu_ref_conc/binary/rules.v.html                   │
│  4.69      4.58  -0.1100   -2.35%    116  coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html │
│ 0.110   0.00242  -0.1081  -97.81%    195  coq-iris-examples/theories/logatom/herlihy_wing_queue/hwq.v.html                      │
│ 0.119    0.0121  -0.1068  -89.83%     94  coq-iris-examples/theories/hocap/fg_bag.v.html                                        │
│ 0.138    0.0320  -0.1060  -76.83%    129  coq-iris-examples/theories/hocap/cg_bag.v.html                                        │
│ 0.109   0.00337  -0.1059  -96.91%    333  coq-iris-examples/theories/locks/array_based_queuing_lock/abql.v.html                 │
│ 0.122    0.0167  -0.1058  -86.40%    226  coq-iris-examples/theories/logatom/snapshot/atomic_snapshot.v.html                    │
└─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

🪑 GitLab Bench Job

Tragicus requested a review from a team as a code owner January 7, 2025 12:04

coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jan 7, 2025

Tragicus mentioned this pull request Jan 14, 2025

Optimize non-applicative stack nodes #20048

Closed

6 tasks

SkySkimmer added the needs: progress Work in progress: awaiting action from the author. label Jan 23, 2025

Tragicus added 8 commits February 19, 2025 14:50

typo

a098f12

debug

4aef05a

debug evarconv

d5c3489

debug

abdcea6

debug evarsolve

2e78e70

debug

2529fb1

retype in eta_constructor

7f978a5

Tragicus mentioned this pull request Feb 20, 2025

Adapt to rocq#19987 UniMath/UniMath#1995

Merged

revert retyping in eta-constructor

4a31e7c

benediktahrens pushed a commit to UniMath/UniMath that referenced this pull request Feb 20, 2025

Adapt to rocq#19987 (#1995)

81868f9

rocq-prover/rocq#19987 refolds terms before using them to instantiate evars. There is one instance where we need to unfold by hand.

debug

503a1d2

Tragicus mentioned this pull request Feb 21, 2025

Adapt to rocq#19987 HoTT/Coq-HoTT#2223

Merged

This was referenced Mar 21, 2025

adapt to rocq#19987 math-comp/odd-order#67

Merged

Lock gedge, gnode and gface rocq-community/fourcolor#73

Merged

Adapt to rocq#19987 math-comp/analysis#1532

Merged

Adapt to Rocq#19987 MetaRocq/metarocq#1152

Open

cleanup

160ce24

Tragicus force-pushed the fold-evd branch from 2e974c5 to 160ce24 Compare May 23, 2025 08:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refold before evar instantiation #19987

Refold before evar instantiation #19987

Uh oh!

Tragicus commented Jan 7, 2025 •

edited

Loading

Uh oh!

gares commented Jan 7, 2025

Uh oh!

coqbot-app bot commented Jan 7, 2025

Uh oh!

gares commented Jan 8, 2025

Uh oh!

Tragicus commented May 23, 2025

Uh oh!

gares commented May 31, 2025

Uh oh!

coqbot-app bot commented May 31, 2025

Uh oh!

Uh oh!

Refold before evar instantiation #19987

Are you sure you want to change the base?

Refold before evar instantiation #19987

Uh oh!

Conversation

Tragicus commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gares commented Jan 7, 2025

Uh oh!

coqbot-app bot commented Jan 7, 2025

Uh oh!

gares commented Jan 8, 2025

Uh oh!

Tragicus commented May 23, 2025

Uh oh!

gares commented May 31, 2025

Uh oh!

coqbot-app bot commented May 31, 2025

Uh oh!

Uh oh!

Tragicus commented Jan 7, 2025 •

edited

Loading