-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: foundry update 4af6cfa #445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix eth_signTransaction request and response * fixup! Fix eth_signTransaction request and response * Hardcode test nonce and fee values * Fix test signed result
* feat(anvil-core): EIP4844 variant support * chore: proper support when converting txs * feat: add more type support * chore: lock * feat: missing type conversions, decoding test * use correct eip check * force no blob hashes for eip1559 * feat: support sidecar with 4844 types * fmt * feat: turn on c-kzg revm feature * chore: add new invalid tx errors * feat: execution validation steps * feat: enable c-kzg * feat: use main branch for consensus, update * chore: rename * lockfile * fmt * fmt * fmt * clippy * feat: update blob fees * set current blob excess gas and price when creating block * blob gas checks * clippy * chore: remove unneeded fns * chore: handle fee history * chore: add excess blob gas and price to feehistory cache * chore: remove unused * chore: properly sum cumulative blob gas * chore: rewrite validation checks * chore: handle eip4844 variant when decoding * max blob validation check * chore: correct and rename blob fee capp err * feat: fee history response changes * docs * several fee fixes * chore: set blob gas used on rpc response * fix: use primitives types * fix: satisfy clippy * feat(anvil/tests): can_send_eip4844_transaction - fails * use sidecar builder in tests * fix: tx_req_to_typed * nits * fix: return `blob_gas_price` and `blob_gas_used` in tx receipt * nits * fix: gas_price calc in backend::tx_build and nits * feat(anvil-tests): `can_send_multiple_blobs_in_one_tx`, `cannot_exceed_six_blobs` * nits * fix: eip4844 test * nits Co-authored-by: DaniPopes <[email protected]> * feat(anvil-test): 4844 - test should fail. * fix(anvil): check MAX_BLOB_GAS_PER_BLOCK in tx executor * nits * fix: blob error handling * nits * type nits * nit --------- Co-authored-by: Yash Atreya <[email protected]> Co-authored-by: DaniPopes <[email protected]>
* fix: avoid panic on missing CREATE2 deployer * rm println * rm println
This reverts commit cc24a3e.
chore: make clippy happy
* fix(anvil): include blob hashes in call env * nit
* fix: more gas estimation checks for transfer * rustmft * flip value check * style
* fix(anvil): set blob fields in genesis * track blob fields in fork * nit + test
* patch compilers * update fixture regex * update patch * update patch * update patch * update patch * update patch * update patch * update patch * update patch * rm patch
* chore(invariant) - rename TargetAbiSelector * Rename contract_abi to artifact
* feat: remove most of ethers * chore: update deny
* chore: bump alloy 17c5650 * fix * fix * fix * fix * bump
…s (#7865) * chore(invariant) - reuse code to collect push bytes and storage values * Remove build_initial_state, move logic in EvmFuzzState::new
* chore(invariant): remove persist_state config, commit to backend by default * Test snekmate fix * Point to latest snekmate commit
…ry-zksync into foundry-update-4af6cfa
…ry-zksync into foundry-update-4af6cfa
Co-authored-by: Nisheeth Barthwal <[email protected]>
Co-authored-by: Nisheeth Barthwal <[email protected]>
Co-authored-by: Nisheeth Barthwal <[email protected]>
Jrigada
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Karrq
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Updates foundry to 4af6cfa (2024-06-19)
This is a major update and brings forth many significant changes, breaking or otherwise:
forge create
commands manually as they are printed in the output. Alternatively the known deployed libraries can be specified infoundry.toml
. There is an ongoing investigation on how to re-introduce this functionality in a way that is sustainable in the long run.The following important foundry updates are included (from their release page):
Nightly (2024-06-02)
ContractData
foundry-rs/foundry#8022)Nightly (2024-05-02)
eth_signTransaction
request and response foundry-rs/foundry#7804)Note
This update can potentially introduce edge case regressions, but we are relying on our test suite to catch them early.