-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add post pull script to run install #32062
Conversation
ping @dipikabh @teoli2003 |
Thanks for adding this feature, @OnkarRuikar. It indeed can be frustrating to realize that all that was needed was a If |
eef4724
to
061ee75
Compare
I've updated the feature. Now it gives a warning message instead of actually running the install command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the warning message, @OnkarRuikar
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Brian Thomas Smith <[email protected]>
0e8421b
to
c11ae8a
Compare
Hi @OnkarRuikar, feel free to ping one of us to merge this after you've had a chance to fix the failing check. Thanks! |
People have faced issues after pulling new code from origin or base and they have spent hours figuring out what was wrong. Almost all the time simple
yarn install
makes thing right again.The PR adds post-merge script which runs when a contributor runs
git pull
orgit pull upstream main
. The script has following properties:main
yarn install
on very first runpackage.json
modified then runyarn install
<-- this is the main featurepackage.json
hasn't been modified since last pullYari does
yarn install
on every precommit, which will be very annoying in content. Next best thing is to do it immediately after pull/merge inmain
branch.