Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Give users the option to log Python warnings #1294

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Dec 22, 2022

This came up during Office Hours on 2022-12-21. Tap developers are only seeing the get_next_page_token deprecation warning in CI, which is not terrible, but it'd be nice if a warning was also logged during the tap execution.


📚 Documentation preview 📚: https://meltano-sdk--1294.org.readthedocs.build/en/1294/

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #1294 (babdc83) into main (3fcac26) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
+ Coverage   85.19%   85.25%   +0.05%     
==========================================
  Files          54       57       +3     
  Lines        4722     4740      +18     
  Branches      803      803              
==========================================
+ Hits         4023     4041      +18     
  Misses        507      507              
  Partials      192      192              
Impacted Files Coverage Δ
singer_sdk/cli/__init__.py 100.00% <100.00%> (ø)
singer_sdk/cli/command.py 100.00% <100.00%> (ø)
singer_sdk/cli/common_options.py 100.00% <100.00%> (ø)
singer_sdk/mapper_base.py 56.89% <100.00%> (ø)
singer_sdk/streams/rest.py 86.66% <100.00%> (+0.24%) ⬆️
singer_sdk/tap_base.py 68.66% <100.00%> (ø)
singer_sdk/target_base.py 86.95% <100.00%> (ø)
singer_sdk/utils/deprecation.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon force-pushed the 1292-feature-emit-log-at-warning-level-to-match-python-warning-for-deprecation-of-get_next_page_token branch from 1df7d48 to 608c0cc Compare December 23, 2022 02:38
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 2, 2023 22:20
edgarrmondragon and others added 6 commits January 2, 2023 16:20
…tch-python-warning-for-deprecation-of-get_next_page_token
…tch-python-warning-for-deprecation-of-get_next_page_token
…tch-python-warning-for-deprecation-of-get_next_page_token
…tch-python-warning-for-deprecation-of-get_next_page_token
…tch-python-warning-for-deprecation-of-get_next_page_token
…tch-python-warning-for-deprecation-of-get_next_page_token
@edgarrmondragon edgarrmondragon force-pushed the 1292-feature-emit-log-at-warning-level-to-match-python-warning-for-deprecation-of-get_next_page_token branch from 1405408 to dcacc35 Compare February 9, 2023 02:30
…tch-python-warning-for-deprecation-of-get_next_page_token
@edgarrmondragon edgarrmondragon force-pushed the 1292-feature-emit-log-at-warning-level-to-match-python-warning-for-deprecation-of-get_next_page_token branch from dcacc35 to babdc83 Compare February 9, 2023 02:32
@edgarrmondragon edgarrmondragon removed the request for review from afolson February 9, 2023 02:40
@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 18, 2023
@edgarrmondragon
Copy link
Collaborator Author

superseded by #768

@edgarrmondragon edgarrmondragon deleted the 1292-feature-emit-log-at-warning-level-to-match-python-warning-for-deprecation-of-get_next_page_token branch July 19, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Emit log at warning level to match Python warning for deprecation of get_next_page_token
1 participant