-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen height on tablet vs keyboard #1162
base: main
Are you sure you want to change the base?
Conversation
Preview build will be at |
Removes extra space on the right of HTML when the simulator is closed
This reverts commit 640c5e4.
display={mode === "collapsed" ? "none" : undefined} | ||
visibility={mode === "collapsed" ? "hidden" : undefined} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes some of the extra space around the UI that is added when the simulator is collapsed. visibility: hidden
does not change the layout of the document, display: none
does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed since we are aiming to have the keyboard overlay the UI instead of having a shifting action bar
Aim
Previously (https://github.com/microbit-foundation/python-editor-v3/issues/11), "If we stick with a bottom toolbar then the keyboard on iPad is problematic. On Android the viewport resizes. On iOS it's overlapped."
This PR aims to update the tablet UI behaviour such that the keyboard now overlays the UI for iOS and Android. This behaviour is alines with the keyboard experiences in the Raspberry pi and MakeCode editor.
In the instance where the height is shorter than what the sidebar allows, the entire UI will become scrollable in the Y-direction such that the min-height of the UI is the height of the side bar.
In the instance where the width is shorter than what the simulator width + sidebar width allows, the entire UI will become scrollable in the X-direction such that the min-width will be simulator width + sidebar width.
Still to do
To do for future