Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Multiline Pill Picker #2121

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Jan 27, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Created a new component, MultilinePillPicker, for macOS. Built in SwiftUI and wrapped (via [MSF]MultilinePillPickerView) for AppKit. Supports two rows of controls, with optional actions on selection.

Binary change

n/a - no measurement system for macOS as of yet.

Verification

Verified light and dark modes, enabled and disabled modes. See video and screenshots below.

Visual Verification
MultilinePillPickerRecording.mp4
Enabled Disabled
light-enabled light-disabled
dark-enabled dark-disabled

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber added the New API This PR introduces new API label Jan 27, 2025
@mischreiber mischreiber requested review from a team as code owners January 27, 2025 21:45
@mischreiber mischreiber enabled auto-merge (squash) January 27, 2025 22:39
@mischreiber mischreiber disabled auto-merge January 28, 2025 04:40
@mischreiber mischreiber merged commit fa970f4 into microsoft:main Jan 28, 2025
7 checks passed
@mischreiber mischreiber deleted the multilinePillPicker branch January 28, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New API This PR introduces new API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants