-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Multiline Pill Picker #2121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joannaquu
reviewed
Jan 27, 2025
Sources/FluentUI_macOS/Components/MultilinePillPicker/MultilinePillPicker.swift
Outdated
Show resolved
Hide resolved
joannaquu
reviewed
Jan 27, 2025
Sources/FluentUI_macOS/Components/MultilinePillPicker/MultilinePillPicker.swift
Show resolved
Hide resolved
joannaquu
approved these changes
Jan 27, 2025
Saadnajmi
approved these changes
Jan 27, 2025
Saadnajmi
reviewed
Jan 27, 2025
...s/FluentUIDemo_macOS/FluentUITestViewControllers/TestMultilinePillPickerViewController.swift
Outdated
Show resolved
Hide resolved
Saadnajmi
reviewed
Jan 27, 2025
Sources/FluentUI_macOS/Components/MultilinePillPicker/MultilinePillPicker.swift
Outdated
Show resolved
Hide resolved
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Created a new component,
MultilinePillPicker
, for macOS. Built in SwiftUI and wrapped (via[MSF]MultilinePillPickerView
) for AppKit. Supports two rows of controls, with optional actions on selection.Binary change
n/a - no measurement system for macOS as of yet.
Verification
Verified light and dark modes, enabled and disabled modes. See video and screenshots below.
Visual Verification
MultilinePillPickerRecording.mp4
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow