Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix layout regression #27266

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 13, 2021

Fix #27138 (comment)


Next up, we might want to look into #27043 (comment) before the release of v5.0.0-beta.1, it's a regression, and seems to have a large impact (my assumption is that we would quickly get a bug report if we release it). The transition is now technically strict mode compatible 👌 but does no longer serves its original product purpose. I will see what I can do to improve it tomorrow. The simplest might be to remove the transition, it would already be better, but I hope that with more effort we can get the best of the two worlds, a simple, strict mode transition, with a great UX.

@oliviertassinari oliviertassinari requested a review from eps1lon July 13, 2021 23:12
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 13, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 13, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against da8ba17

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix #27138 (comment)

Please write a proper bug report.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 14, 2021

Fix #27138 (comment)

@eps1lon Are you able to reproduce the issue? So far I have provided the following information:

  1. A URL for the reproduction: https://next--material-ui.netlify.app/guides/migration-v4/
  2. A screenshot that shows the issue:

Capture d’écran 2021-07-13 à 11 59 45

What else would you like to see? I don't get what you mean by providing a proper bug report. It doesn't seem to be about opening a GitHub issue, what you seem to ask for is about providing more information?

Maybe an extra piece of information that could make it clearer: the issue triggers when the viewport is larger than lg (when the side nav triggers), meaning for screen widths that is larger than 1200px. But this can already be inferred from the screenshot and for which 83.3% of the G.A. sessions are above.

@eps1lon
Copy link
Member

eps1lon commented Jul 14, 2021

What else would you like to see? I don't get what you mean by providing a proper bug report. It doesn't seem to be about opening a GitHub issue, what you seem to ask for is about providing more information?

You don't have to fill out an issue. The template is for people who don't know how to file a proper bug report. It doesn't have to be follow rigidly but the content needs to be the same. And you seem to willfully ignore this. I've told you this before. It's up to you to show that you are willing to improve. I probably had by now half a dozen of instances where I told you what you're missing. I was patient. I explained it. This credit is now gone.

@oliviertassinari oliviertassinari merged commit 8bba02a into mui:next Jul 14, 2021
@oliviertassinari oliviertassinari deleted the docs-fix-layout branch July 14, 2021 09:19
eps1lon added a commit that referenced this pull request Jul 14, 2021
@eps1lon
Copy link
Member

eps1lon commented Jul 14, 2021

Reverting accidental merge in #27269

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 14, 2021

I have merged to unlock the situation. I think that #27269 helps move the discussion forward, thanks for opening it 👍. I can't act on these two feedback:

Please write a proper bug report.

the content needs to be the same

For me, it seems to suggest that you can't reproduce the issue, but I don't know what I'm missing, nor what you have tried. I think that our incentive on the bug reports is to provide enough information so that anyone can reproduce the issue.

oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Jul 14, 2021
oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants