-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix layout regression #27266
[docs] Fix layout regression #27266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix #27138 (comment)
Please write a proper bug report.
@eps1lon Are you able to reproduce the issue? So far I have provided the following information:
What else would you like to see? I don't get what you mean by providing a proper bug report. It doesn't seem to be about opening a GitHub issue, what you seem to ask for is about providing more information? Maybe an extra piece of information that could make it clearer: the issue triggers when the viewport is larger than lg (when the side nav triggers), meaning for screen widths that is larger than 1200px. But this can already be inferred from the screenshot and for which 83.3% of the G.A. sessions are above. |
You don't have to fill out an issue. The template is for people who don't know how to file a proper bug report. It doesn't have to be follow rigidly but the content needs to be the same. And you seem to willfully ignore this. I've told you this before. It's up to you to show that you are willing to improve. I probably had by now half a dozen of instances where I told you what you're missing. I was patient. I explained it. This credit is now gone. |
Reverting accidental merge in #27269 |
I have merged to unlock the situation. I think that #27269 helps move the discussion forward, thanks for opening it 👍. I can't act on these two feedback:
For me, it seems to suggest that you can't reproduce the issue, but I don't know what I'm missing, nor what you have tried. I think that our incentive on the bug reports is to provide enough information so that anyone can reproduce the issue. |
Fix #27138 (comment)
Next up, we might want to look into #27043 (comment) before the release of v5.0.0-beta.1, it's a regression, and seems to have a large impact (my assumption is that we would quickly get a bug report if we release it). The transition is now technically strict mode compatible 👌 but does no longer serves its original product purpose. I will see what I can do to improve it tomorrow. The simplest might be to remove the transition, it would already be better, but I hope that with more effort we can get the best of the two worlds, a simple, strict mode transition, with a great UX.