Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[docs] Fix layout regression" #27269

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 14, 2021

Reverts #27266 which was accidentally merged. There was no reproduction provided and we don't merge "fixes" that are unconfirmed.

Broke layout on

  • Chrome Version 91.0.4472.114 (Official Build) (64-bit) Ubuntu 20.04
  • Firefox Version 89.0.2 Ubuntu 20.04
  • Chrome Version 91.0.4472.114 (Official Build) (64-bit) macOS Catalina
  • Safari Version 14.1.1 (Official Build) (64-bit) macOS Catalina

Screenshot from 2021-07-14 11-54-02

@eps1lon eps1lon added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Jul 14, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 14, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 929219c

@oliviertassinari
Copy link
Member

@eps1lon Nice spotted, I can reproduce the issue on the API pages. 👍 for fixing it. If we revert this one, I propose, we revert the issue from the root: #27138. Otherwise, we can work on a solution that cover these two constraints.

@eps1lon
Copy link
Member Author

eps1lon commented Jul 14, 2021

We can revert #27138 once we have identified the issue.

@eps1lon
Copy link
Member Author

eps1lon commented Jul 14, 2021

@eps1lon Nice spotted, I can reproduce the issue on the API pages.

This reproduces on /api, /components, /guides etc. Including the page that you claimed was fixed.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 14, 2021

The PR leads to this issue:

  1. Open https://deploy-preview-27269--material-ui.netlify.app/guides/migration-v4/ on any browsers, resize the screen to be 1400px wide.
  2. See that the TOC is partially visible

Capture d’écran 2021-07-14 à 12 03 39

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 14, 2021

I might have figured out why you couldn't reproduce my bug report, and why I couldn't understand what information was missing. It seems that it's about the screen width. Do you have a large display by any chance? Mine is small. I have updated #27269 (comment) accordingly.

If we look at the source of my screenshot it's 2724 pixels wide, with a x2 pixel ratio, my viewport is 1362px. Does it help?

@eps1lon
Copy link
Member Author

eps1lon commented Jul 14, 2021

We can discuss the repro of the your bug somewhere else. The screen size is not the problem. I've resized all the way from 1px to 2510px and could not reproduce it. You're missing some more information about your environment. Might be pixel density.

@eps1lon eps1lon merged commit 6c2e1a5 into next Jul 14, 2021
@eps1lon eps1lon deleted the revert-27266-docs-fix-layout branch July 14, 2021 10:23
@eps1lon
Copy link
Member Author

eps1lon commented Jul 14, 2021

It's especially confusing since now you report a different issue. I can only encourage you to go through the bug report steps since you seem to be unable to write a coherent bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants