Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text fix: customisations -> customizations #26574

Closed
wants to merge 1 commit into from

Conversation

Gootector
Copy link
Contributor

Text fix: customisations -> customizations

Greetings,
Gootector

Resolves: #NNNNN

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Text fix: customisations -> customizations

Greetings,
Gootector
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 18, 2025
@@ -208,7 +208,7 @@
<li>Multiple improvements to the Plugin API</li>
<li>Implement changing palette and palette cell properties on fly</li>
<li>Current workspace is automatically saved on each action that changes the workspace</li>
<li>Palettes and workspaces can be reset to the default state defined by the workspace you started customisations from</li>
<li>Palettes and workspaces can be reset to the default state defined by the workspace you started customizations from</li>
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is completly and utterly outdated, the release history ends with 4.0.1 and has no usefull data since 3.3.4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not my fault. Useless files should be removed from the repo.

Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trie, your change there looks good to me, just the rest of that file is not in a good shape
TRhe file itself is (most probably) not useless, but it's content is.

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Feb 18, 2025

I'm afraid that if we merge this, it will cause conflicts in #26257, which would not be nice for the author of that PR because it's very big and complex. We will review that PR after the 4.5 release, so let's put this one on hold for now. (Edit: I see now that GitHub says that there are already conflicts, but still, let's not make those worse.)

@Gootector Gootector closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants