Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text fix: customisations -> customizations #26574

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@
<li>Multiple improvements to the Plugin API</li>
<li>Implement changing palette and palette cell properties on fly</li>
<li>Current workspace is automatically saved on each action that changes the workspace</li>
<li>Palettes and workspaces can be reset to the default state defined by the workspace you started customisations from</li>
<li>Palettes and workspaces can be reset to the default state defined by the workspace you started customizations from</li>
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is completly and utterly outdated, the release history ends with 4.0.1 and has no usefull data since 3.3.4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not my fault. Useless files should be removed from the repo.

Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trie, your change there looks good to me, just the rest of that file is not in a good shape
TRhe file itself is (most probably) not useless, but it's content is.

<li>Improve algorithm for determining start point for note input</li>
<li>Move the viewport to show actual changes in the score if they are outside of the current view</li>
</ul>
Expand Down
4 changes: 2 additions & 2 deletions share/plugins/tuning/tuning.qml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ MuseScore {

property var history: 0;

// set true if customisations are made to the tuning
// set true if customizations are made to the tuning
property var modified: false;

/**
Expand Down Expand Up @@ -1296,7 +1296,7 @@ MuseScore {
id: quitDialog
title: "Quit?"
text: "Do you want to quit the plugin?"
detailedText: "It looks like you have made customisations to this tuning, you could save them to a file before quitting if you like."
detailedText: "It looks like you have made customizations to this tuning, you could save them to a file before quitting if you like."
standardButtons: [StandardButton.Ok, StandardButton.Cancel]
onAccepted: {
quit()
Expand Down
4 changes: 2 additions & 2 deletions share/plugins/tuning_modal/Modal_Tuning.qml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ MuseScore {

property var history: 0;

// set true if customisations are made to the tuning
// set true if customizations are made to the tuning
property var modified: false;

/**
Expand Down Expand Up @@ -1421,7 +1421,7 @@ MuseScore {
id: quitDialog
title: "Quit?"
text: "Do you want to quit the plugin?"
detailedText: "It looks like you have made customisations to this tuning, you could save them to a file before quitting if you like."
detailedText: "It looks like you have made customizations to this tuning, you could save them to a file before quitting if you like."
standardButtons: [StandardButton.Ok, StandardButton.Cancel]
onAccepted: {
quit()
Expand Down
4 changes: 2 additions & 2 deletions share/plugins/tuning_modal/Temperaments.qml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ MuseScore {

property var history: 0;

// set true if customisations are made to the tuning
// set true if customizations are made to the tuning
property var modified: false;

/**
Expand Down Expand Up @@ -1421,7 +1421,7 @@ MuseScore {
id: quitDialog
title: "Quit?"
text: "Do you want to quit the plugin?"
detailedText: "It looks like you have made customisations to this tuning, you could save them to a file before quitting if you like."
detailedText: "It looks like you have made customizations to this tuning, you could save them to a file before quitting if you like."
standardButtons: [StandardButton.Ok, StandardButton.Cancel]
onAccepted: {
quit()
Expand Down
Loading