Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #26598: Crash after adding instrument, Undo and Redo #26648

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Fix #26598: Crash after adding instrument, Undo and Redo #26648

merged 4 commits into from
Feb 21, 2025
+83 −49

Conversation

RomanPudashkin
Copy link
Contributor

@RomanPudashkin RomanPudashkin commented Feb 21, 2025 •
edited
Loading

Resolves: #26598
Resolves: #26601

@RomanPudashkin
optimization: update m_parts & m_systemObjectStaves first and then se…
700f616 
…nd notifications

Thus, we will have all the necessary data in LayoutPanelTreeModel::load()
@RomanPudashkin
fix musescore#26598: one global connect to undoStack()->changesChannel()
fed13bb 
instead of reconnecting to it inside each SystemObjectsLayerTreeItem
@RomanPudashkin
optimization: don't update panel if it's not visible on screen
af02fba
@RomanPudashkin
optimization: collect system objects for all staves at once
a6ec17b 
As it's quite an expensive operation
@RomanPudashkin RomanPudashkin force-pushed the undo_add_instrument_crash branch from ad88af8 to a6ec17b Compare February 21, 2025 14:43
@DmitryArefiev
Copy link
Contributor

Tested #26598 (crash only), #26601 on Win10, Mac13.6, LinuxUbuntu24.04.2 LTS - FIXED

@RomanPudashkin RomanPudashkin merged commit 416deee into musescore:master Feb 21, 2025
11 checks passed
@RomanPudashkin RomanPudashkin deleted the undo_add_instrument_crash branch February 21, 2025 15:59
This was referenced Feb 21, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-spa mike-spa mike-spa approved these changes

Assignees

@DmitryArefiev DmitryArefiev

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@RomanPudashkin @DmitryArefiev @mike-spa