Better Formula Editing (by ChieveiT) #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@myliang : any thoughts on this PR? (e.g., too large, or don't like the proposed changes, or like the proposed changes but want to see it refactored) |
|
@myliang : happy to make changes (and may ask ChieveiT for help) if there's something the maintainers don't like. |
|
@myliang : what are your thoughts on this PR? |
you should split and push |
|
@myliang : just confirming that I understand, you want me to decrease the size of this PR by splitting into smaller changes? |
|
@myliang - I've split off the first three commits from this PR into individual PRs:
I've also updated this PR to just include the final commit (better formula editing) for your review. |
jkirschner
force-pushed
the
better-formula-editing
branch
from
25d10f5
to
ee61ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modified version of #309 that cleans up some of the commit history and removes functionality that will be obsoleted by a subsequent formula.js integration PR.
According to ChieveiT, it does the following:
better disable editing (moved to Fix missed case of disabling cell edits #464)delete weird input element in selector (moved to delete weird input element in selector #466)fix alphabet indexAt and stringAt (moved to fix alphabet indexAt and stringAt #465)