Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Remove old canvas code (no-changelog) #13343

Merged
merged 14 commits into from
Feb 19, 2025

Conversation

alexgrozav
Copy link
Member

Summary

Removes code exclusive to the old canvas.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-519/cleanup-old-canvas-code

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 18, 2025
@alexgrozav alexgrozav self-assigned this Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 82.75862% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/editor-ui/src/App.vue 0.00% 7 Missing ⚠️
packages/editor-ui/src/utils/nodeViewUtils.ts 76.92% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

netroy
netroy previously approved these changes Feb 18, 2025
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Feb 18, 2025

n8n    Run #9327

Run Properties:  status check failed Failed #9327  •  git commit 32c0e2f7c0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-519-cleanup-old-canvas-code
Run status status check failed Failed #9327
Run duration 11m 30s
Commit git commit 32c0e2f7c0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 15
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 292
View all changes introduced in this branch ↗︎

Tests for review

Failed  10-undo-redo.cy.ts • 14 failed tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo deleting node using context menu Screenshots Video
Undo/Redo > should undo/redo deleting node using keyboard shortcut Screenshots Video
Undo/Redo > should undo/redo deleting node between two connected nodes Screenshots Video
Undo/Redo > should undo/redo deleting whole workflow Screenshots Video
Undo/Redo > should undo/redo moving nodes Screenshots Video
Undo/Redo > should undo/redo deleting a connection using context menu Screenshots Video
Undo/Redo > should undo/redo disabling a node using context menu Screenshots Video
Undo/Redo > should undo/redo disabling a node using keyboard shortcut Screenshots Video
Undo/Redo > should undo/redo disabling multiple nodes Screenshots Video
Undo/Redo > should undo/redo duplicating a node Screenshots Video
The first 10 failed tests are shown, see all 14 tests in Cypress Cloud.
Failed  20-workflow-executions.cy.ts • 1 failed test

View Output Video

Test Artifacts
Workflow Executions > when new workflow is not saved > should open executions tab Test Replay Screenshots Video
Failed  26-resource-locator.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  48-subworkflow-inputs.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  19-execution.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 42 specs in Cypress Cloud.

Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Workflow Executions > when workflow is saved > should load items and auto scroll after filter change Test Replay Screenshots Video
Flakiness  17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Credential Usage in Cross Shared Workflows > should show all credentials from all personal projects the workflow's been shared into for the global owner Test Replay Screenshots Video

netroy
netroy previously approved these changes Feb 18, 2025
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 143cb22 into master Feb 19, 2025
39 checks passed
@alexgrozav alexgrozav deleted the cat-519-cleanup-old-canvas-code branch February 19, 2025 11:10
@janober
Copy link
Member

janober commented Feb 25, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants