Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Funding Tracing #519

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

doitian
Copy link
Member

@doitian doitian commented Feb 25, 2025

  • Refactor ckb tx tracing for better concurenccy. All tracing transactions will be stored in a queue. A new actor, CkbTxTracingActor, will be responsible for polling the status of these transactions sequentially.
  • A new actor InFlightCkbTxActor is responsible for resending the failed funding, commitment, and closing transactions.
  • The reestablished channel will be recovered in the AwaitingChannelReady state. While recovery is possible in other states, doing so may lead to significant code duplication. To address this, I propose creating a detailed to-do list and tackling the issues step by step as I familiarize myself with the codebase.

Handling Failing Test Cases

Two payment-related test cases are currently failing. The cause of these failures is unclear, and assistance has been requested from @chenyukang. To reproduce these issues, you can run the following command:

cargo test test_send_payment_three_nodes_send_each_other_no_wait
cargo test test_send_payment_with_max_nodes

@doitian doitian marked this pull request as draft February 25, 2025 07:54
@doitian doitian force-pushed the feature/funding-tx-tracing branch from 308e9ea to c1827ce Compare February 25, 2025 08:02
@doitian doitian force-pushed the feature/funding-tx-tracing branch 2 times, most recently from eb8d875 to e2a579b Compare February 25, 2025 10:39
@doitian doitian marked this pull request as ready for review February 25, 2025 20:04
@doitian
Copy link
Member Author

doitian commented Feb 25, 2025

Payment test cases are still unstable, some of them may fail when ran together.

@doitian

This comment was marked as resolved.

@chenyukang
Copy link
Collaborator

Payment test cases are still unstable, some of them may fail when ran together.

please have a try with TEST_TEMP_RETAIN=1 ?

@doitian doitian force-pushed the feature/funding-tx-tracing branch 4 times, most recently from da97865 to fde5c80 Compare February 28, 2025 17:04
@doitian doitian force-pushed the feature/funding-tx-tracing branch from 272bc33 to 7fed967 Compare March 1, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[open_channel] tx committed ,but state is stuck in AWAITING_CHANNEL_READY
2 participants