Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXstress contribution: stress-strain analysis #1039

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

NXstress contribution: stress-strain analysis #1039

wants to merge 31 commits into from

Conversation

woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Mar 24, 2022 •
edited
Loading

Application definition for stress-strain analysis as defined by the EASI-STRESS consortium.

NXstress HTML documenation:

https://hdf5.gitlab-pages.esrf.fr/nexus/nxstress_examples/classes/applications/NXstress.html#nxstress

A short summary of the definition

ENTRY@NXentry
    peaks@NXreflections  -->  serves as input for stress-strain calculations
    fit@NXprocess  -->  diagnostics of how `peaks` was generated
        peak_parameters@NXparameters
        background_parameters@NXparameters
        DIFFRACTOGRAM@NXdata
    instrument$NXinstrument  -->  meanly for geometry
        source@NXsource
        DETECTOR@NXdetector
            TRANSFORMATIONS@NXtransformation
        beam_intensity_profile@NXbeam
            TRANSFORMATIONS@NXtransformation
    sample_description$NXsample  -->  meanly for geometry
        gauge_volume@NXparameters
        TRANSFORMATIONS@NXtransformation
    notes@NXnote  -->  free

Some examples:

@woutdenolf woutdenolf marked this pull request as ready for review March 24, 2022 16:46
@woutdenolf woutdenolf changed the title contribution for stress-strain analysis WIP: contribution for stress-strain analysis Mar 24, 2022
@woutdenolf woutdenolf marked this pull request as draft March 24, 2022 16:50
@woutdenolf woutdenolf added definitions contributions Add or modify a contributed definition labels Mar 24, 2022
@woutdenolf woutdenolf force-pushed the contrib_stress_strain branch 6 times, most recently from 0f4148c to b76c745 Compare March 26, 2022 17:47
@woutdenolf woutdenolf force-pushed the contrib_stress_strain branch 2 times, most recently from b217e8b to d9b00a5 Compare April 8, 2022 17:11
@woutdenolf woutdenolf force-pushed the contrib_stress_strain branch 8 times, most recently from 4277c3a to 2716c10 Compare April 27, 2022 12:48
@prjemian prjemian added this to the NXDL 2022.06 milestone Jun 14, 2022
@prjemian prjemian modified the milestones: NXDL 2022.06, NXDL 2023.06 Jun 24, 2022
@woutdenolf woutdenolf force-pushed the contrib_stress_strain branch 3 times, most recently from 8d6398d to 725e93f Compare June 30, 2022 22:01
woutdenolf and others added 21 commits October 23, 2024 09:44
@woutdenolf
beam_intensity_profile becomes NXbeam instead of NXcollection
c515f47
@woutdenolf
use NXnote groups with a required calibration_type field for calibration
71dd3f8
@woutdenolf
add sin2psi diffraction type and qmagnitude in case cUnits is not eno…
fed1d3d 
…ugh (like sin2pi)
@woutdenolf
qmagnitude is redundant (it is center with type momentum transfer) an…
0a5a477 
…d can cause confusion
@woutdenolf
fix NXsample transformations
3942a3b
@woutdenolf
fix indentation
74822e0
@woutdenolf
fix link name
e730395
@woutdenolf
use enumerations
87f4be3
@woutdenolf
rename diffraction_type to processing_type, use enumeration and add m…
205b412 
…ore descriptions
@woutdenolf
fix PDF build
e6f4552
@woutdenolf
fix math blocks
f77a42b
@aapaecklar @woutdenolf
Update NXstress.nxdl.xml
bf85e61
@aapaecklar @woutdenolf
Update contributed_definitions/NXstress.nxdl.xml
48c2ac9 
Deleted the energy dispersive information.
@aapaecklar @woutdenolf
Update contributed_definitions/NXstress.nxdl.xml
9ab83c7 
Change back again the angstrom symbol
@woutdenolf @aapaecklar
Update contributed_definitions/NXstress.nxdl.xml
d7976cf 
Co-authored-by: Arnold Paecklar <[email protected]>
@woutdenolf
fix misconception about energy/wavelength
8381e90
@woutdenolf @phyy-nx
Update contributed_definitions/NXstress.nxdl.xml
83e2c03 
Co-authored-by: Aaron S. Brewster <[email protected]>
@woutdenolf
fix missing peak_parameters groups
64a1a0b
@woutdenolf
use NXparameters where appropriate
b901566
@woutdenolf
cannot be distinguished by a reader when the names are optional
f4f35c4
@woutdenolf
fix typo
ad5428d
@woutdenolf
Copy link
Contributor Author

woutdenolf commented Oct 23, 2024 •
edited
Loading

Moved NXstress to applications

To be done:

  • Repeat the symbols imported from included classes.
  • Drop optional="true" since it is the default
  • Consistent usage of optional="false" vs. minOccurs="1"

@woutdenolf woutdenolf requested review from a team and removed request for a team November 23, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-cabeza s-cabeza s-cabeza left review comments

@phyy-nx phyy-nx phyy-nx left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
code camp contributions Add or modify a contributed definition definitions
Projects
NIAC 2024 project
Status: To finish after the meeting
Milestone
later
Development

Successfully merging this pull request may close these issues.
6 participants
@woutdenolf @phyy-nx @prjemian @aapaecklar @mkuehbach @s-cabeza