Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use REMOVE_GTF_BRACKETS gtf (ch_gtf) as input to RNA_ALIGN, instead of ch_filtered_gtf #135

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

iraiosub
Copy link

@iraiosub iraiosub commented Mar 24, 2025

fixes #133 use REMOVE_GTF_BRACKETS gtf output (ch_gtf) as input to RNA_ALIGN, instead of ch_filtered_gtf.
This is necessary because all the transcripts need to be present for accurate mapping with STAR (junctions).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/clipseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@iraiosub iraiosub added the enhancement Improvement for existing functionality label Mar 24, 2025
@iraiosub
Copy link
Author

@kkuret and i thought this might be best, but let us know if indeed the filtered GTF should be used for alignment

@iraiosub iraiosub added bug Something isn't working and removed enhancement Improvement for existing functionality labels Mar 24, 2025
@CharlotteAnne CharlotteAnne merged commit 77ae82b into nf-core:feat-2-0 Mar 25, 2025
35 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the input to STAR_ALIGN module to use unfiltered GTF file instead of filtered gtf with: --sjdbGTFfile
3 participants