Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook to validate environment.ymls #7086

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Nov 25, 2024

  • style: Add sort-simple-yaml
  • style: Add yaml type
  • style: Change comments to name of pre-commit hooks
  • style: Add validation for environment.ymls

Also validates our new GitHub action that lives in the repo.

args: ["--schemafile", "modules/yaml-schema.json"]
- id: check-jsonschema
# match meta.ymls in one of the subdirectories of subworkflows/nf-core
name: "Validate environment.ymls against schema"
files: ^.*/environment\.yml$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this path be ^modules/nf-core/.*/environment\.yml$?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants