You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In previous versions of the tools manifest.author was required for the files_unchanged check and this was checked up front and if it wasn't present the test was skipped (source code).
In 3.1.2 we now pull names from eithermanifest.author or manifest.contributors (source code). However neither of these are checked for up front now (source code).
This can cause an unhandled error to be raised if neithermanifest.author or manifest.contributors is present or if they resolve to an empty string (e.g. if contributors do not have a name field set see: pairgenomealign example).
We should either check for the presence of the author/contributors up front or add a check at the point of determination of names to similarly ignore the lint test.
Command used and terminal output
System information
No response
The text was updated successfully, but these errors were encountered:
Description of the bug
In previous versions of the tools
manifest.author
was required for thefiles_unchanged
check and this was checked up front and if it wasn't present the test was skipped (source code).In
3.1.2
we now pull names from eithermanifest.author
ormanifest.contributors
(source code). However neither of these are checked for up front now (source code).This can cause an unhandled error to be raised if neither
manifest.author
ormanifest.contributors
is present or if they resolve to an empty string (e.g. ifcontributors
do not have aname
field set see: pairgenomealign example).We should either check for the presence of the
author
/contributors
up front or add a check at the point of determination ofnames
to similarlyignore
the lint test.Command used and terminal output
System information
No response
The text was updated successfully, but these errors were encountered: