Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmux: Disable tmux-sensible by Default (bug fix) #6091

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

gen740
Copy link
Contributor

@gen740 gen740 commented Nov 16, 2024

Description

In #5952, it was pointed out that tmux has changed how it handles shells, and because of this, the tmux.shell option doesn’t work properly unless tmux-sensible is turned off.

However, tmux-sensible hasn’t been updated for over two years, as mentioned here. Since it’s no longer actively maintained, keeping it enabled by default is becoming more of a problem.

This PR suggests turning off tmux-sensible by default to avoid these issues and improve usability.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee

@gen740
Copy link
Contributor Author

gen740 commented Nov 27, 2024

@rycee

This is my first contribution to home-manager. Since tmux.nix lacks meta.maintainers, I wasn't sure who to CC.

I noticed there hasn't been any activity on this PR for about a week, so just checking if there's anything else I can do.

Thanks!

@gen740 gen740 changed the title tmux: Disable tmux-sensible by Default tmux: Disable tmux-sensible by Default (bug fix) Nov 27, 2024
@rycee rycee force-pushed the change-tmux-default-option branch from 2d7eba3 to 210b05d Compare November 28, 2024 09:47
@rycee rycee merged commit f83dc9f into nix-community:master Nov 28, 2024
2 of 3 checks passed
@gen740 gen740 deleted the change-tmux-default-option branch November 28, 2024 10:35
@rycee
Copy link
Member

rycee commented Nov 28, 2024

Thanks! Merged to master now 🙂

@ambroisie ambroisie mentioned this pull request Nov 28, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants