Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: deprecate never throw behaviour in fs.existsSync #55753

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Ceres6
Copy link
Contributor

@Ceres6 Ceres6 commented Nov 6, 2024

This PR attempts to deprecate the behaviour of returning false on argument validation in fs.existsSync

cc @joyeecheung @BridgeAR

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 6, 2024
lib/fs.js Outdated Show resolved Hide resolved
@Ceres6 Ceres6 force-pushed the chore/deprecate-fs-existSync-never-throw branch from ac72356 to c3d38fb Compare November 6, 2024 17:02
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (fb8de03) to head (2cedeac).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55753   +/-   ##
=======================================
  Coverage   87.95%   87.96%           
=======================================
  Files         656      656           
  Lines      188304   188373   +69     
  Branches    35967    35982   +15     
=======================================
+ Hits       165630   165702   +72     
+ Misses      15840    15839    -1     
+ Partials     6834     6832    -2     
Files with missing lines Coverage Δ
lib/fs.js 93.35% <100.00%> (+<0.01%) ⬆️

... and 35 files with indirect coverage changes

@aduh95 aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 14, 2024
doc/api/deprecations.md Outdated Show resolved Hide resolved
@aduh95
Copy link
Contributor

aduh95 commented Nov 25, 2024

This needs a rebase now that #55892 landed

@Ceres6 Ceres6 force-pushed the chore/deprecate-fs-existSync-never-throw branch from 53692f9 to 26a540d Compare November 26, 2024 07:37
@Ceres6 Ceres6 force-pushed the chore/deprecate-fs-existSync-never-throw branch from 26a540d to 4963d03 Compare November 26, 2024 07:41
@Ceres6
Copy link
Contributor Author

Ceres6 commented Nov 26, 2024

@aduh95 rebased

lib/fs.js Outdated Show resolved Hide resolved
@LiviaMedeiros LiviaMedeiros added the needs-citgm PRs that need a CITGM CI run. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants