-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: deprecate never throw behaviour in fs.existsSync #55753
Open
Ceres6
wants to merge
10
commits into
nodejs:main
Choose a base branch
from
Ceres6:chore/deprecate-fs-existSync-never-throw
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fs: deprecate never throw behaviour in fs.existsSync #55753
Ceres6
wants to merge
10
commits into
nodejs:main
from
Ceres6:chore/deprecate-fs-existSync-never-throw
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
Issues and PRs related to the fs subsystem / file system.
needs-ci
PRs that need a full CI run.
labels
Nov 6, 2024
richardlau
reviewed
Nov 6, 2024
Ceres6
force-pushed
the
chore/deprecate-fs-existSync-never-throw
branch
from
November 6, 2024 17:02
ac72356
to
c3d38fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55753 +/- ##
=======================================
Coverage 87.95% 87.96%
=======================================
Files 656 656
Lines 188304 188373 +69
Branches 35967 35982 +15
=======================================
+ Hits 165630 165702 +72
+ Misses 15840 15839 -1
+ Partials 6834 6832 -2
|
aduh95
added
the
semver-major
PRs that contain breaking changes and should be released in the next major version.
label
Nov 14, 2024
aduh95
reviewed
Nov 14, 2024
aduh95
reviewed
Nov 14, 2024
This needs a rebase now that #55892 landed |
Ceres6
force-pushed
the
chore/deprecate-fs-existSync-never-throw
branch
from
November 26, 2024 07:37
53692f9
to
26a540d
Compare
Ceres6
force-pushed
the
chore/deprecate-fs-existSync-never-throw
branch
from
November 26, 2024 07:41
26a540d
to
4963d03
Compare
@aduh95 rebased |
aduh95
reviewed
Nov 26, 2024
aduh95
reviewed
Nov 26, 2024
Co-authored-by: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fs
Issues and PRs related to the fs subsystem / file system.
needs-ci
PRs that need a full CI run.
needs-citgm
PRs that need a CITGM CI run.
semver-major
PRs that contain breaking changes and should be released in the next major version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to deprecate the behaviour of returning false on argument validation in
fs.existsSync
cc @joyeecheung @BridgeAR