doc: deprecate passing invalid types in fs.existsSync #55892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
deprecations
|
The subsystem should be |
Ceres6
force-pushed
the
chore/deprecate-fs-existSync-invalid-types
branch
from
9734812
to
024adec
Compare
Ceres6
changed the title
Fixed |
RedYetiDev
reviewed
Nov 17, 2024
Co-authored-by: Aviv Keller <[email protected]>
|
@aduh95 @RedYetiDev are we okay now? |
aduh95
reviewed
Nov 20, 2024
aduh95
reviewed
Nov 20, 2024
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
|
@aduh95 comment fixed, anything else? |
|
/cc @nodejs/fs @joyeecheung |
jasnell
approved these changes
Nov 23, 2024
lpinca
approved these changes
Nov 25, 2024
jazelly
approved these changes
Nov 25, 2024
|
Landed in a01319a |
Ceres6
added a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55892 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
PR-URL: #55892 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precursor to #55753
cc @aduh95