Bump keyseq to 0.4.0 and add action::trigger* convenience systems, CHANGE NOTATION, and prep for bevy-input-sequence 0.6.0 release.
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test fails but that's ok.
When the last keychord fails to match, we should check if it itself matches something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Elm,
I added some convenience methods to trigger events instead of sending them. But that's not my whopper.
My whopper is that I changed keyseq and published 0.4.0. After a lot of deliberation, I decided to switch to capitalized modifier keys, so
Ctrl-Ainstead ofctrl-A. I also added a feature flag to permit the even more standardCtrl+A. This change breaks any keyseq users, which right now is only this crate, so I say break 'em while they're small.My hope is to get
bevy-input-sequenceout the door and then push my first release of bevy_minibuffer for bevy 0.14 before bevy 0.15 gets published, which may be as soon as this weekend.If you don't viscerally object to the notation change, let me know how I can help. If you're ok with this PR and permit it, I can publish to crates.io since we're both owners. That's purely an offer to help and expedite if you lack time or access.
Be well!
-Shane