Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph: backend: dnnl: fix check for sdpa #2457

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

graph: backend: dnnl: fix check for sdpa #2457

wants to merge 2 commits into from
+7 −3

Conversation

ElaineBao
Copy link
Contributor

Description

There are two fixes:

  • fix select check for sdpa primitive: sdpa prmitive doesn't support select after scale(optional) and mask(optional), filter them out.
  • add check for sdp decomp kernel: when cpu runtime = threadpool, sdpa with implicit causal mask will first run into sdp decomp kernel, which is not supported, filter them out.

@ElaineBao ElaineBao added the component:graph-api Codeowner: @oneapi-src/onednn-graph label Jan 21, 2025
@ElaineBao ElaineBao self-assigned this Jan 21, 2025
@ElaineBao ElaineBao requested a review from a team as a code owner January 21, 2025 05:50
@ElaineBao
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph

@ElaineBao
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph

@ElaineBao
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph
enable build_cpu_runtime_thrpool_eigen

@ElaineBao
graph: backend: dnnl: add check for sdp decomp kernel
1256f35 
filter out implicit causal mask in sdp decomp kernel
@ElaineBao
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph
enable build_cpu_runtime_thrpool_eigen

@ElaineBao ElaineBao mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyhintel gyhintel gyhintel approved these changes

@avmanerikar avmanerikar avmanerikar approved these changes

@xiang1guo xiang1guo xiang1guo approved these changes

@rongzha1 rongzha1 rongzha1 approved these changes

Assignees

@ElaineBao ElaineBao

Labels
component:graph-api Codeowner: @oneapi-src/onednn-graph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ElaineBao @rongzha1 @xiang1guo @avmanerikar @gyhintel