improve UI of accounts screen #115
Conversation
|
hey @laxyapahuja, you'll have to add all the dimensions, texts and colors in dimens.xml, strings.xml and colors.xml respectively. |
|
updated. |
|
I can still see some hardcoded texts, colors and dimensions. can you check again? |
app/src/main/kotlin/org/mifos/mobile/cn/ui/mifos/customerAccounts/CustomerAccountFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/mifos/mobile/cn/ui/mifos/customerAccounts/CustomerAccountFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/mifos/mobile/cn/ui/mifos/customerAccounts/CustomerAccountFragment.kt
Outdated
Show resolved
Hide resolved
|
Updated. |
|
@Rachittt all this code was already existing. i haven't touched it and it is not advised to correct already existing code :) |
|
@laxyapahuja, when the user clicks on the loan button, a plus icon will appear on the top right side which will redirect the user to Apply for Loan screen. Please check the prototype video of mockup design from '0:15' to get reference. |
updated. |
|
Use RecyclerView to show lists. |
There already was a recycler view for recent transactions. I've used that fragment as a nested fragment in dashboard activity as that was the most optimal solution and didn't require me to change the code much. |
|
The tint color for deposit and loan is not correct. Cards are also not as per the design. The position, size, and color of the plus symbol are not correct. Remove that Toolbar. |
|
@laxyapahuja Please correct the conflicting files and the changes requested above. |
Issue Fix
Fixes #103
Description
Updated the UI to the new redesign design.
Screenshots
Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.