redesign: transfer and amount screens #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GOVINDDIXIT
reviewed
Jan 19, 2020
laxyapahuja
reviewed
Jan 19, 2020
laxyapahuja
reviewed
Jan 19, 2020
laxyapahuja
reviewed
Jan 19, 2020
|
I compared this with your mockups and the amount screen contact info seems to not have good padding compared to the mockup. |
|
updated. |
laxyapahuja
reviewed
Jan 19, 2020
laxyapahuja
reviewed
Jan 20, 2020
laxyapahuja
reviewed
Jan 20, 2020
laxyapahuja
reviewed
Jan 20, 2020
laxyapahuja
reviewed
Jan 20, 2020
laxyapahuja
reviewed
Jan 20, 2020
|
@laxyapahuja, not removing spaces because i feel like it is important to separate them. |
luckyman20
reviewed
Jan 20, 2020
This was referenced Jan 24, 2020
2 tasks
2 tasks
|
@Rachittt Can you please make whether you intended to put a QR code scanner where this current image of QR code is there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixes #107
Screenshots:
Transfer Screen
Amount Screen
Description
Addition of Fonts, Unfocused BoxStrokeColor of TextInputLayout, and Bottom Navigation bar will be done in different PRs as discussed with a mentor.
Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.