Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and add react hooks support #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

kouhin
Copy link

@kouhin kouhin commented May 17, 2019

  • Update deps
  • Remove dependencies of react-reffect (redux)
  • Refactoring with React Hooks and add useHelmet()
  • Merge changes from react-helmet 6 with modifications (webpack -> rollup)

@kouhin kouhin requested a review from herablog May 17, 2019 05:20
@codecov-io
Copy link

codecov-io commented May 17, 2019

Codecov Report

Merging #10 into master will decrease coverage by 1.12%.
The diff coverage is 95.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   97.57%   96.45%   -1.13%     
==========================================
  Files           3        4       +1     
  Lines         289      367      +78     
==========================================
+ Hits          282      354      +72     
- Misses          7       13       +6
Impacted Files Coverage Δ
src/HelmetUtils.js 96.87% <100%> (+0.01%) ⬆️
src/modules.js 86.95% <86.95%> (ø)
src/Helmet.js 97.22% <97.14%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aafaed...9eec6a3. Read the comment docs.

@kouhin kouhin force-pushed the next branch 2 times, most recently from 9b99d1b to dd61733 Compare May 21, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants