Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧(helm) rework chart based on jenny helm chart #252

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wilbrdt
Copy link
Contributor

@wilbrdt wilbrdt commented May 16, 2024

Purpose

Rework Warren Helm chart based on the work done on Jenny Helm chart in PR openfun/charts#5

Proposal

  • Jobs for database migration or static collection are abstracted into a single
    job template
  • Env variables are now processed in the helper template
  • Removed unused HorizontalPodAutoscaler
  • Add startup probes for migration checks
  • Migration jobs are now executed post helm installation/upgrade
  • Removed unnecessary security context variables
  • Add a nginx container alongside warren-app to serve static files
  • Rework postgresql values to have a functional Helm chart on a local cluster
  • Update Helm chart README.md

@wilbrdt wilbrdt self-assigned this May 16, 2024
Copy link

changeset-bot bot commented May 16, 2024

⚠️ No Changeset found

Latest commit: bd35e66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wilbrdt wilbrdt force-pushed the rework-helm-chart branch 4 times, most recently from 71b3323 to e174e19 Compare May 17, 2024 13:34
@wilbrdt wilbrdt changed the title wip 🔧(helm) rework chart based on jenny helm chart May 17, 2024
@wilbrdt wilbrdt marked this pull request as ready for review May 17, 2024 13:35
@wilbrdt wilbrdt requested review from lunika and claudusd May 17, 2024 13:36
Copy link

@claudusd claudusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, just some questions to discuss about.

src/helm/warren/charts/api/templates/ingress.yaml Outdated Show resolved Hide resolved
src/helm/warren/charts/api/templates/jobs.yaml Outdated Show resolved Hide resolved
src/helm/warren/charts/api/templates/jobs.yaml Outdated Show resolved Hide resolved
@wilbrdt wilbrdt requested a review from claudusd May 21, 2024 09:59
@wilbrdt wilbrdt force-pushed the rework-helm-chart branch from a8f8752 to aa28caa Compare May 21, 2024 14:37
@wilbrdt wilbrdt requested a review from lunika May 22, 2024 14:35
@wilbrdt wilbrdt force-pushed the rework-helm-chart branch from 4f4f0e9 to 3ebc99b Compare May 29, 2024 12:27
@wilbrdt wilbrdt force-pushed the rework-helm-chart branch from bb89b4f to a9661b3 Compare June 7, 2024 07:41
@wilbrdt wilbrdt force-pushed the rework-helm-chart branch from 8f59a1c to 01b80e6 Compare July 4, 2024 14:51
@wilbrdt wilbrdt force-pushed the rework-helm-chart branch from 7b8769c to d8bf4ef Compare August 22, 2024 12:01
Rework Warren Helm chart based on the work done on Jenny Helm chart in PR
openfun/charts#5
Changes done in this commit:
- Jobs for database migration or static collection are abstracted into a single
  job template
- Env variables are now processed in the helper template
- Removed unused HorizontalPodAutoscaler
- Add startup probes for migration checks
- Migration jobs are now executed post helm installation/upgrade
- Removed unnecessary security context variables
- Add a nginx container alongside warren-app to serve static files
- Rework postgresql values to have a functional Helm chart on a local cluster
- Update Helm chart README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants