8351319: AOT cache support for custom class loaders broken since JDK-8348426

[iklam]

Since JDK-8348426 (Generate binary file for -XX:AOTMode=record -XX:AOTConfiguration=file), the AOT cache no longer contains classes intended for custom class loaders (these are called "unregistered classes" in CDS terminology).

The fix is simple -- we already remember the set of unregistered classes in the AOT configuration file. We just need to add them into the final AOT cache (see changes in finalImageRecipes.cpp).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8351319: AOT cache support for custom class loaders broken since JDK-8348426 (Bug - P2)

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)
• Matias Saavedra Silva (@matias9927 - Reviewer) Review applies to ccea0a41
• John R Rose (@rose00 - Reviewer) Review applies to ccea0a41

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23926/head:pull/23926
$ git checkout pull/23926

Update a local copy of the PR:
$ git checkout pull/23926
$ git pull https://git.openjdk.org/jdk.git pull/23926/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23926

View PR using the GUI difftool:
$ git pr show -t 23926

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23926.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351319: AOT cache support for custom class loaders broken since JDK-8348426

Reviewed-by: ccheung, matsaave, jrose

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 5f2a604: 8353840: JNativeScan should not abort for missing classes
• 1f21da7: 8351462: Improve robustness of String concatenation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (a2723bfb)
• 05: Full (17dcf9c0)
• 04: Full (fa825b65)
• 03: Full - Incremental (c02a611e)
• 02: Full (ccea0a41)
• 01: Full - Incremental (41ae5507)
• 00: Full (2cdb5f80)

[bridgekeeper]

@iklam This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[calvinccheung]

LGTM

[matias9927]

LGTM!

[rose00]

Good.

I suppose there already tests for the other end of the process, where an unregistered class in the AOT cache is actually used. What are those tests?

[matias9927]

Changes look good!

[iklam]

Good.

I suppose there already tests for the other end of the process, where an unregistered class in the AOT cache is actually used. What are those tests?

It turns out that the existing tests only check for unregistered classes in the classical CDS archive. I added a test in BulkLoaderTest.java to check the AOT cache and found a bug. Fixed in c02a611

[calvinccheung]

Updates look good.

[iklam]

Thanks @calvinccheung @matias9927 @rose00 for the review
/integrate

[openjdk]

Going to push as commit e3f26b0.
Since your change was applied there have been 8 commits pushed to the master branch:

• 4954a33: 8350563: C2 compilation fails because PhaseCCP does not reach a fixpoint
• 4a242e3: 8354213: Restore pointless unicode characters to ASCII
• 776e1cf: 8353041: NeverBranchNode causes incorrect block frequency calculation
• ... and 5 more: https://git.openjdk.org/jdk/compare/567c6885a377e5641deef9cd3498f79c5346cd6a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit e3f26b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.