-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/no more weird runtime api encoding #1162
Open
camfairchild
wants to merge
9
commits into
devnet-ready
Choose a base branch
from
feat/no-more-weird-runtime-api-encoding
base: devnet-ready
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/no more weird runtime api encoding #1162
camfairchild
wants to merge
9
commits into
devnet-ready
from
feat/no-more-weird-runtime-api-encoding
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam0x17
added
the
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
label
Jan 21, 2025
camfairchild
added
the
breaking-change
This PR introduces a noteworthy breaking change
label
Jan 27, 2025
@opentensor/cerebrum / @opentensor/gyrus / @opentensor/cortex breaking change detected! Please prepare accordingly! |
We'll hold on merging this until bittensor/btcli publish the impl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
This PR introduces a noteworthy breaking change
do not merge
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the runtime APIs to only use the actual types they are expecting, instead of encoding/decoding to
Vec<u8>
.This means we can decode runtime API results using just the chain metadata, so we can more easily support future changes to the APIs.
This breaks old clients, but the timing with RAO makes it worthwhile, as old clients will break anyway.
Type of Change
Breaking Change
Clients upgrading should be grabbing their type information from the V15 Metadata on the chain.
They should also be able to see these runtime APIs listed there, with their expected input and output types, and the encoding for said types.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctly