-
Notifications
You must be signed in to change notification settings - Fork 59
refactor: guest bindings #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Avaneesh-axiom
wants to merge
37
commits into
release-v1.2.1-rc.0
Choose a base branch
from
refactor/guest-library-reorg-final
base: release-v1.2.1-rc.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: guest bindings #1613
Avaneesh-axiom
wants to merge
37
commits into
release-v1.2.1-rc.0
from
refactor/guest-library-reorg-final
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1027e21
to
88bf100
Compare
@@ -26,11 +29,15 @@ To [leverage](./overview.md) compile-time known moduli for performance, you decl | |||
```rust | |||
moduli_declare! { | |||
Bls12_381Fp { modulus = "0x1a0111ea397fe69a4b1ba7b6434bacd764774b84f38512bf6730d2a0f6b0f6241eabfffeb153ffffb9feffffffffaaab" }, | |||
Bn254Fp { modulus = "21888242871839275222246405745257275088696311157297823662689037894645226208583" }, | |||
Bn254Fp { | |||
modulus = "21888242871839275222246405745257275088696311157297823662689037894645226208583", impl_field = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment in the old PR on impl_field
auto detection
56207ac
to
63931ab
Compare
2a47052
to
c9c0989
Compare
63931ab
to
6fbc163
Compare
cd66383
to
828553b
Compare
This comment has been minimized.
This comment has been minimized.
56c28d0
to
1d30696
Compare
Commit: 1d30696 |
fabaddf
to
656670c
Compare
Base automatically changed from
feat/binding-primitive-libs
to
release-v1.2.1-rc.0
May 13, 2025 01:23
656670c
to
bea1fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes parts of the guest libraries for each extension. These libraries are to be moved into a new repo as part of the guest library re-org.
Summary of changes for each extension:
halo2curves_shims
module, along with a minimal set of constants remain in the openvm repo, while the bn254 and bls12_381 implementations were moved outsha256
andset_sha256
functions were deleted, leaving behind only the Rust bindingkeccak256
andset_keccak256
functions were deleted, leaving behind only the Rust bindingNotes:
mod_sqrt
implementation was moved from the ecc extension to the algebra extensionBenchmarks and examples are now outdated since they depend on guest libraries that no longer exist. These need to be redesigned and rewritten to use the new guest libraries. I wasn't able to easily port the benchmarks and examples because depending on the new guest libraries creates weird linker issues (I'm guessing due to double-importing openvm).
TODO: switch all deps to main after merge
Closes INT-3788