Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu: update to 9.1.3 #25980

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

qemu: update to 9.1.3 #25980

wants to merge 2 commits into from

Conversation

vooon
Copy link
Contributor

@vooon vooon commented Feb 15, 2025

Maintainer: @yousong
Compile tested: x86_64, OpenWrt master
Run tested: x86_64 host, KVM for qemu-x86_64-softmmu + Bios VM.

Description:

Replace to fix openwrt#25209

Signed-off-by: Vladimir Ermakov <[email protected]>
- Update version
- Refresh patches

Signed-off-by: Vladimir Ermakov <[email protected]>
@janh
Copy link
Contributor

janh commented Feb 15, 2025

The commit message of "qemu: fix guest agent patch" is not accurate. As explained in #25209 (comment), the segfault is already fixed in QEMU 9.1.2.

(I'm sorry for any confusion by my earlier message which said that the updated patch from Alpine does fix the issue. But as it turned out, it just happens to no longer trigger it.)

@vooon
Copy link
Contributor Author

vooon commented Feb 15, 2025

@janh so you suggest that better to use your patch? The system anyway are busybox based, so there no need in that fallback mech at all. So in my opinion alpine just do it right...

@janh
Copy link
Contributor

janh commented Feb 15, 2025

No, the patch itself is absolutely fine! I also don't really care which solution gets accepted in the end.

It's just that the commit description ("Replace to fix #25209") is not accurate. Because that issue is about the segfault, which is already fixed by updating to QEMU 9.1.2. (It just isn't in 24.10 so far).

@vooon vooon marked this pull request as ready for review February 15, 2025 19:45
@vooon
Copy link
Contributor Author

vooon commented Feb 15, 2025

@janh ok.

I've tested it. Friendly ping @neheb @yousong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants