-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Modules to Github Actions #277
Comments
@jameesjohn i would like to work on |
Done @nlok5923. You can start working on it. |
@jameesjohn can i work on this checkPullRequestLabels.js |
@khanjasir90 Would you still be interested in this issue? |
Yes |
@khanjasir90 Done. |
Hi @vojtechjelinek @jameesjohn! Sorry for this very trivial question, but what are the technical requirements to be able to solve a task in this issue? This being my second issue ever I am a bit confused. I would really like to acquaint myself with the skills needed and contribute to this issue. |
You should know JavaScript and the GitHub Actions API. I also recommend reading through the migration guide https://github.com/oppia/oppiabot/wiki/Migrating-to-Github-Actions and the sample PR #276 |
I see. I will read up on it. I would like to give it a try. @vojtechjelinek can you please assign me |
@SaurabhJamadagni Done. |
Hi @vojtechjelinek, could you please assign me |
@SaurabhJamadagni Sure |
Hi @vojtechjelinek! I am going through the migration guide and I have completed the 'Migrating A Feature' steps mentioned in the documentation. I am having trouble understanding a few steps in the 'Migrating Tests' section of the guide. Could you please help me understand the step 'Mocking' mentioned? Do I have to make changes to the spec file? Thanks for sparing your time! |
@SaurabhJamadagni Yep, you need to modify the specs, because now the tests will probably fail. Let me know if you need more info. |
@vojtechjelinek by looking at the reference PR, I understand that I will have to remove all instances of 'checkBranch' from all the spec files. Is there anything else I have to do next or is that the final step in the migration for the respective file? I am extremely sorry if these are trivial questions. |
Yeah, then you will need to check if all the tests are still passing and if not you will need to modify the so that they pass. |
@viveky45 Done. |
Hi @vojtechjelinek, I would like to work on |
@coder1706 Done. |
hi @vojtechjelinek, can u please assign me the ciChecks.js module ? |
@vojtechjelinek can u please review the PR #300 |
I want to work on this issue . Please assign me this issue . |
The Oppiabot project is currently in a hybrid state comprising of both Github Actions and Probot.
This issue aims to migrate the features to GitHub actions and track the progress of doing that.
To be able to contribute to this, you need to read the migration guide which can be found here.
Sample PRs on migrating to Github Actions can be found here.
Available Modules to Migrate:
Done:
The text was updated successfully, but these errors were encountered: