-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated ciChecks Module from probot to github actions #300
Conversation
@vojtechjelinek please let me know if any corrections are to be made! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Took a pass. Why is the .env.save and package-lock.json file added?
Unassigning @vojtechjelinek since the review is done. |
Hi @Ketan1502, it looks like some changes were requested on this pull request by @vojtechjelinek. PTAL. Thanks! |
@vojtechjelinek any further changes required? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left one more comment.
Hi @Ketan1502, it looks like some changes were requested on this pull request by @vojtechjelinek. PTAL. Thanks! |
@vojtechjelinek can it be merged now? |
@Ketan1502 Did you test all these changes according to the instructions in the PR description. |
yes, all the tests have passed @vojtechjelinek |
@Ketan1502 But did you test your changes manually? |
I tested using npm test |
@Ketan1502 The tests are failing though |
Hey! @vojtechjelinek, I have corrected the lint checks but facing issues in the frontend checks. I have cross checked my front end checks with the frontend checks of the sample PR and both were showing the similar errors but the sample PR's checks have passed but mine are not, can u please help me out to understand my fault. |
Hi @Ketan1502. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
Explanation
The ciChecks.js module is successfully migrated from probot to github actions as mentioned in issue #277
Checklist