fix(transformer/decorator): decoration disappear due to incorrect statement address

[Dunqing]

close: #9058
close: #9129

[Dunqing]

• fix(transformer/decorator): decoration disappear due to incorrect statement address #9062 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #9062 will not alter performance

_{Comparing 02-12-fix_transformer_decorator_decoration_disappear_due_to_incorrect_statement_address (bad08cf) with main (cf969e2)}

Summary

✅ 33 untouched benchmarks

[overlookmotel]

I rebased on latest main to fix merge conflicts and tidied up whitespace in test fixtures, but made no substantive changes. I'll follow up with a couple of style nit things in separate PRs.

[overlookmotel]

Merge activity

• Feb 21, 5:59 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Feb 21, 5:59 AM EST: A user added this pull request to the Graphite merge queue.
• Feb 21, 6:03 AM EST: A user merged this pull request with the Graphite merge queue.

[overlookmotel]

@Dunqing You were not keen on passing stmt_address as a param into transform_class_impl and transform_class_declaration_without_class_decorators.

A way to avoid that would be to record the Address as self.stmt_address, and then pull that value out of self again in transform_class_declaration_without_class_decorators.

But personally I think the way you have it now is good. The call chain is short, these functions have few parameters, and those params are all small (8 bytes each). So probably stmt_address just stays in a register the whole time. That's more efficient than writing to self.stmt_address, which would definitely incur a memory write every time.

It makes very little difference either way - this is micro-optimization stuff - but just mentioning it as you said you didn't like passing it as a param.