-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Switch from @import to @use" #7154
Conversation
Generate changelog in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with reverting for now and spending more time (unrushed) to debug later. Thanks @ggdouglas.
@ggdouglas Sounds good! I did a quick comparison and see that some imports were missed for function calls in a few places. SASS compile did not complain because I guess it assumes they might be native CSS functions. I can put up a new PR with corrections. |
Reverts #7074
We are reverting this PR due to style regressions discovered while testing
develop
before release. Notably, the borders and shadows around text inputs and popovers are missing. Additionally, there are instances in the documentation where margins and padding differ. Given the wide scope of these changes, we have decided to revert the original change for now and revisit it in a follow-up PR with more thorough manual regression testing of Blueprint's styles.Examples:
@justinbhopper - Apologies for not catching this at the time of review. I'd be happy to revisit and re-review your changes. We will push this forward again while being more mindful of style regressions..