Enums roundtrip unknown variants #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
bmoylan
commented
Sep 29, 2020
asanderson15
approved these changes
Oct 5, 2020
asanderson15
requested changes
Oct 5, 2020
tabboud
reviewed
Oct 5, 2020
| ), | ||
| Body: []astgen.ASTStmt{ | ||
| statement.NewReturn( | ||
| expression.NewCallFunction("werror", "Convert", |
There was a problem hiding this comment.
What is the value in adding in the additional werror.Convert given the NewInvalidArgument will return a proper error?
There was a problem hiding this comment.
Adam asked the same question on Slack. This might be exposing a deficiency with how we implemented the conjure error, but because it's not a werror it doesn't have a stacktrace. I added the werror.Convert as low as possible to preserve the stack frame(s) between here and the next werror.Wrap.
asanderson15
approved these changes
Oct 5, 2020
tabboud
approved these changes
Oct 5, 2020
This was referenced Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Unknown enum variants were all assigned the
UNKNOWNvalue, which is not in line with the conjure spec that specifies they should be stored and round-trippable. Partially addresses #24 (unions require more thought).After this PR
==COMMIT_MSG==
Enums now preserve unknown variant values. The
UNKNOWNvalue has been removed.==COMMIT_MSG==
Possible downsides?
This might be a breaking change, especially if people are assuming the generated values are exhaustive (e.g. using switch statements without default cases)
This change is