Skip to content

Allow to tune down the logging on console. #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pilhuhn
Copy link
Collaborator

@pilhuhn pilhuhn commented Mar 14, 2025

Without this PR, all analytics actions were unconditionally logged to console.
This PR introduces a verbose init prop, that allows to switch this off.

TODO: how do we want to deal with this for the console provider, which is explicitly made to allow for logging to browser console?

@pilhuhn pilhuhn requested a review from rebeccaalpert March 14, 2025 09:28
@patternfly-build
Copy link

patternfly-build commented Mar 14, 2025

@@ -57,6 +58,8 @@ const initProps: InitProps = {
};
```

Note, that there is also a key `verbose` that allows you to enable debugging output on web-browser console. By default, this is set to `false`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note, that there is also a key `verbose` that allows you to enable debugging output on web-browser console. By default, this is set to `false`.
- **Note:** To enable output debugging via the web-browser console, set the `verbose` key to `true`. By default, this is set to `false`.

just the same suggestions I made in #492

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 492 contains this PR. I originally thought the "more harmless" one could go in the 2.2.0 release.

@pilhuhn
Copy link
Collaborator Author

pilhuhn commented Apr 9, 2025

I am closing this because #492 includes this change

@pilhuhn pilhuhn closed this Apr 9, 2025
@pilhuhn pilhuhn deleted the less-verbose branch April 9, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants