-
Notifications
You must be signed in to change notification settings - Fork 29
Major overhaul of provider init and Umami Provider #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview: https://chatbot-pr-chatbot-492.surge.sh A11y report: https://chatbot-pr-chatbot-492-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few content suggestions 👍
packages/module/patternfly-docs/content/extensions/chatbot/examples/Analytics/Analytics.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Analytics/Analytics.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Analytics/Analytics.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Analytics/Analytics.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Analytics/Analytics.md
Outdated
Show resolved
Hide resolved
…mples/Analytics/Analytics.md Co-authored-by: Erin Donehoo <[email protected]>
…mples/Analytics/Analytics.md Co-authored-by: Erin Donehoo <[email protected]>
…mples/Analytics/Analytics.md Co-authored-by: Erin Donehoo <[email protected]>
Co-authored-by: Erin Donehoo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me, but can't test it really.
packages/module/patternfly-docs/content/extensions/chatbot/examples/Analytics/Analytics.md
Outdated
Show resolved
Hide resolved
…mples/Analytics/Analytics.md Co-authored-by: Erin Donehoo <[email protected]>
🎉 This PR is included in version 2.2.0-prerelease.44 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Explicitly list active providers and only create/initialise the ones in the list.
Umami provider now queues requests until the underlying script is fully loaded and initialised.
This includes #481 -- tuning down the logging with a new
verbose
initProp