Skip to content

Major overhaul of provider init and Umami Provider #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 10, 2025

Conversation

pilhuhn
Copy link
Collaborator

@pilhuhn pilhuhn commented Mar 21, 2025

Explicitly list active providers and only create/initialise the ones in the list.

Umami provider now queues requests until the underlying script is fully loaded and initialised.

This includes #481 -- tuning down the logging with a new verbose initProp

@patternfly-build
Copy link

patternfly-build commented Mar 21, 2025

@rebeccaalpert rebeccaalpert marked this pull request as ready for review April 3, 2025 14:01
Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few content suggestions 👍

pilhuhn and others added 4 commits April 8, 2025 15:41
…mples/Analytics/Analytics.md

Co-authored-by: Erin Donehoo <[email protected]>
…mples/Analytics/Analytics.md

Co-authored-by: Erin Donehoo <[email protected]>
…mples/Analytics/Analytics.md

Co-authored-by: Erin Donehoo <[email protected]>
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but can't test it really.

…mples/Analytics/Analytics.md

Co-authored-by: Erin Donehoo <[email protected]>
@rebeccaalpert rebeccaalpert merged commit 9a802bb into patternfly:main Apr 10, 2025
5 checks passed
Copy link

🎉 This PR is included in version 2.2.0-prerelease.44 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pilhuhn pilhuhn deleted the provider-init branch April 10, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants