feat(DualListSelector): enabled opt-in animations #11837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11837.surge.sh A11y report: https://patternfly-react-pr-11837-a11y.surge.sh |
thatblindgeye
force-pushed
the
dlsAnimations
branch
from
552762f to
c10445c
Compare
thatblindgeye
requested review from
a team,
rebeccaalpert and
wise-king-sullyman
and removed request for
a team
wise-king-sullyman
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11836
ExpandableSection should just work with the core bump and the animation shouldn't occur on page load/refresh.
DLS has the opt-in prop for now and similarly should not animate on page load/refresh nor when
hasAnimationsis false. I added verbiage stating the prop would be removed in the next breaking change, but if we don't want to convey that sort of info in prop docs I can remove itAdditional issues: