[doc] Fix doc of missing DataStore.type: FILEDB #4809
Conversation
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka and
ffjlabo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4809 +/- ##
==========================================
- Coverage 30.62% 28.88% -1.74%
==========================================
Files 227 317 +90
Lines 27207 40369 +13162
==========================================
+ Hits 8331 11662 +3331
- Misses 18216 27779 +9563
- Partials 660 928 +268 ☔ View full report in Codecov by Sentry. |
t-kikuc
changed the title
| @@ -31,7 +31,7 @@ spec: | |||
|
|
|||
| | Field | Type | Description | Required | | |||
| |-|-|-|-| | |||
| | type | string | Which type of data store should be used. Can be one of the following values<br>`FIRESTORE`, `MYSQL`. | Yes | | |||
| | type | string | Which type of data store should be used. Can be one of the following values<br>`FIRESTORE`, `MYSQL`, `FILEDB`. | Yes | | |||
There was a problem hiding this comment.
Guys, this is an alpha feature so I don't really want to mention this directly on this page, wdyt?
There was a problem hiding this comment.
If you guys still want to mention it somewhere, I think we can add a new line to this page
👉 https://pipecd.dev/docs-v0.46.x/feature-status/#control-plane
Be sure to mark that Support file store as data store feature as alpha feature 😉
There was a problem hiding this comment.
@t-kikuc please address this 👀
There was a problem hiding this comment.
Be sure to mark that Support file store as data store feature as alpha feature
That's good, i'll do so
Base branch was modified
This reverts commit 7ef9cd5. Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
|
@ffjlabo plz |
What this PR does / why we need it:
FILEDBwas missed asdatastore.typein the doc although it's supported.FILEDBis defined here:pipecd/pkg/model/datastore.go
Line 22 in 7ef9cd5