Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix doc of missing DataStore.type: FILEDB #4809

Merged
merged 3 commits into from
Apr 1, 2024
Merged

[doc] Fix doc of missing DataStore.type: FILEDB #4809

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ef9cd5
Fix missing DataStore.type: FILEDB
t-kikuc Mar 7, 2024
a14001e
Revert "Fix missing DataStore.type: FILEDB"
t-kikuc Apr 1, 2024
902f723
Add feature-status of FileDB as data store
t-kikuc Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...content/en/docs-dev/user-guide/managing-controlplane/configuration-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:

| Field | Type | Description | Required |
|-|-|-|-|
| type | string | Which type of data store should be used. Can be one of the following values<br>`FIRESTORE`, `MYSQL`. | Yes |
| type | string | Which type of data store should be used. Can be one of the following values<br>`FIRESTORE`, `MYSQL`, `FILEDB`. | Yes |
| config | [DataStoreConfig](#datastoreconfig) | Specific configuration for the datastore type. This must be one of these DataStoreConfig. | Yes |

## DataStoreConfig
Expand Down
2 changes: 1 addition & 1 deletion ...ent/en/docs-v0.46.x/user-guide/managing-controlplane/configuration-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:

| Field | Type | Description | Required |
|-|-|-|-|
| type | string | Which type of data store should be used. Can be one of the following values<br>`FIRESTORE`, `MYSQL`. | Yes |
| type | string | Which type of data store should be used. Can be one of the following values<br>`FIRESTORE`, `MYSQL`, `FILEDB`. | Yes |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guys, this is an alpha feature so I don't really want to mention this directly on this page, wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you guys still want to mention it somewhere, I think we can add a new line to this page
👉 https://pipecd.dev/docs-v0.46.x/feature-status/#control-plane

Be sure to mark that Support file store as data store feature as alpha feature 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-kikuc please address this 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khanhtc1202

Be sure to mark that Support file store as data store feature as alpha feature

That's good, i'll do so

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it

| config | [DataStoreConfig](#datastoreconfig) | Specific configuration for the datastore type. This must be one of these DataStoreConfig. | Yes |

## DataStoreConfig
Expand Down
Loading