Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wait plugin: rename package and file #5462

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Dec 27, 2024

What this PR does:

  • Rename execute package to deployment
  • Rename server.go to plugin.go

Why we need it:

For name consistency.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.12%. Comparing base (77664e1) to head (b57e6b8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/wait/plugin.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5462      +/-   ##
==========================================
- Coverage   26.14%   26.12%   -0.03%     
==========================================
  Files         457      457              
  Lines       49107    49107              
==========================================
- Hits        12841    12831      -10     
- Misses      35244    35253       +9     
- Partials     1022     1023       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t-kikuc t-kikuc merged commit 47a13c3 into master Dec 27, 2024
16 of 18 checks passed
@t-kikuc t-kikuc deleted the refactor-rename-wait branch December 27, 2024 07:47
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants