Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ko): Add Korean language support #255

Merged
merged 1 commit into from
Mar 4, 2025
Merged

i18n(ko): Add Korean language support #255

merged 1 commit into from
Mar 4, 2025

Conversation

zephyranthes03
Copy link
Contributor

Korean support

@jacobgkau jacobgkau requested review from a team March 3, 2025 20:59
@jacobgkau jacobgkau self-assigned this Mar 3, 2025
@jacobgkau
Copy link
Member

jacobgkau commented Mar 3, 2025

@zephyranthes03 For future reference, it's best to avoid using underscores in branch names unless you're using it to build for a specific suite (e.g. _jammy). In this case, korean is not a valid suite, so the build server simply didn't build this for any suites. (The _nobuild string is not special, any non-matching string behaves the same as nobuild.)

I will push the same commit to another branch in order to make it build.

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation's showing up as expected in a user account set to Korean.

@jacobgkau jacobgkau merged commit 03ce661 into master Mar 4, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants