A few UI tweaks #145
Merged
A few UI tweaks #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems more natural this way, rather than having a separator just at the start.
Partially addresses #120. The green check mark icon also seems a bit out of place in this case; not sure what would be best.
mmstick
approved these changes
May 19, 2021
jacobgkau
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the message when flashing errors to improve the confusing behavior involved in #120. Not sure what icon might be better in that case.
It also adds a frame to
ListBoxes which seems better (this matches how all of Gnome Control Center'sListBoxes are styled, for instance), and doesn't allow selection of rows in the summary.